Activity since 2025-08-28

• esp-rs/esp-hal repo issues and pull requests

  • Add support for the ESP32-P4 #643 [jessebraham]

    Still no ETA on this chip, however it's next in line. Hoping to get my hands on some hardware early in the new year...

    • SergioGasquez: Here is the chip support roadmap: #3962 with the current status of the p4

  • Add BLE examples using trouBLE, move some Wi-Fi examples to `qa-test` #3999 [jessebraham] skip-changelog

    Moves embassy_wifi_bench, wifi_bench, and wifi_csi examples to qa-test package Removes blocking BLE example Replaces...

    • bjoernQ: typo "batter" -> "battery"

      • jessebraham: Oops 😁

    • bjoernQ: Thanks

  • Remove all `blocking-network-stack` examples #3831 [MabezDev] examples

    It's pretty clear to me two things: async for any kind of comms is the future troubleBLE and embassy-net are the...

    • jessebraham: Current status: Old BLE examples have been removed, replaced with examples using Embassy and...

  • Use the ram macro instead of assuming the .rwtext section #4005 [bjoernQ] skip-changelog

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • MabezDev: Thanks!

  • `esp-storage`: Consider using the `#[ram]` macro instead of assuming the link section #3954 [bjoernQ]

    See #3953 (comment)

  • Add a way to get/set calibration data #4001 [bjoernQ]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: Maybe these could be nicer with cfg!()?

    • bugadani: Not sure why you cal copy_from_slice here, if we're working with arrays, accessing them directly...

    • MabezDev: LGTM, with a minor name change

      • MabezDev: Suggested change pub fn...

    • MabezDev: Changelog too, sorry 😅

    • bugadani: If this merges without the fix commit, we may have a CI issue 😅

    • bjoernQ: If this merges without the fix commit, we may have a CI issue 😅 oh the fix was meant for a...

  • Re-use WiFi/BLE calibration result #2720 [maufl] package:esp-radio

    Motivations I'd like to save as much power as possible. My use case is a device that spends most time in deep sleep...

  • No implementation of `embedded_hal_async::spi::SpiDevice` in `esp32c3-hal` #1130 [reivilibre]

    I can't see an implementation of SpiDevice in the esp32c3-hal crate. I want one so that I can use...

    • Notliam99: For All Stuck On This Issue: I have found a Solution https://esp32.implrust.com/spi/esp32-spi.html

  • I2C: Fix bus clearing/error recovery #4000 [bugadani]

    Changes are separated into individual commits.

    • bugadani: I don't claim this perfect, but seems to pass a lot more than it did before. I think we can...

    • Dominaezzz: I see green ticks! LGTM

    • bjoernQ: What a relief to see a green checkmark again 😄

  • BLE examples replicate a UUID for both service and a characteristic #2583 [akauppi] bug

    Bug description The BLE examples having the same UUID for both service and one characteristic seems like a...

    • bjoernQ: given we removed the old examples this can be closed

  • feat(example): Add SNTP example to show how to update Rtc to the current time #3995 [AnthonyGrondin]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: Neat, thanks!

  • UART using DMA (via UHCI) #3871 [Szybet]

    Submission Checklist 📝 I have updated existing examples or added new ones (if applicable). I have used cargo...

    • bugadani: Suggested change use...

    • bugadani: Is this supposed to be a reg.conf0().write()? Would write set an incorrect default?

      • Szybet: If it sets the default specified in the technical manual, then yes, it would be incorrect Also,...

      • bugadani: Fair enough, although I think it could still be a write if you overwrite all bits, there's no...

    • bugadani: Current blocker from me is the failing host-tests job, otherwise I haven't looked at this but we...

    • Dominaezzz: LGTM, I'll let Scott or Daniel take a look before merging, since they've commented before

    • bugadani: Thanks so much for working on this 🫶

    • MabezDev: Before this can land, we need HIL tests. Please remove the QA tests, and instead convert/add hil...

  • Allow running specific tests #4009 [bugadani]

    probe-rs supports filtering tests. This PR exposes this to us via the xtask, so that I don't keep accidentally...

    • MabezDev: Nice, I think I've wanted to do this quite a few times before.

  • C3/S3: Remove UHCI1 #4007 [bugadani]

    cc esp-rs/esp-pacs#374 but removing the singleton doesn't need a PAC update

    • bjoernQ

  • Enable UHCI on ESP32-H2 #4008 [bugadani]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: btw, why don't this have any spaces?

      • MabezDev: cc: @Szybet though, I don't think it should matter in the end?

      • Szybet: Works with regular lorem ipsum with spaces, just checked Well in the hours I debugged why it was...

    • MabezDev

  • Initial P4 support tracking issue #2285 [MabezDev] status:blocked chip:esp32p4

    Whilst we don't intend to do a full chip bring-up until the mass production version is released, we would like to...

    • SergioGasquez: Hi @jamesmunns, @rmsyn, sorry for the late reply, I went on vacation. Here is our current chip...

    • jamesmunns: Only questions are when we might expect eco5 silicon to become available, and maybe HOW...

    • bugadani: @jamesmunns I think the best indicator for changes is esp-idf: they have defined a separate...

    • rmsyn: The analogy would be two somewhat different PAC crates for us. So, any HAL work would need to...

    • bugadani: It's not a matter of naming, it's a matter of different hardware behind the PACs. There are more...

  • Integrate 802.15.4 into esp-radio more #4003 [bjoernQ] skip-changelog

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • MabezDev

      • MabezDev: Where did these go?

        • bjoernQ: mhhhh - that's interesting, just removed it after the checks started to check again .... but...

        • bjoernQ: will fix that

      • MabezDev: Looks like it is possible though:...

        • bjoernQ: Maybe with later blobs and/or we need to do something in the 802.15.4 driver - for now Wi-Fi...

        • MabezDev: Do you think we could have detect the use of both and panic in this instance? (we don't have to...

        • bjoernQ: thought about that but decided to not do it (now) since we need a "special solution" to generate...

    • MabezDev: Thanks, LGTM!

  • Update esp-hal-embassy for new executor release #3945 [bugadani] skip-changelog status:blocked

  • Chip support road map #3962 [MabezDev]

    Below is the roadmap of chip support for newly released chips. We offer no fixed timelines here, just our priority...

    • rmsyn: Correct, we still have not received devkits for this device. Our org has some Olimex ESP32-P4...

    • jessebraham: Our org has some Olimex ESP32-P4 devkits, we could send one your way :) Appreciate it, but the...

    • rmsyn: Appreciate it, but the question was regarding the H4 :) We have plenty of ECO4 P4 devkits...

  • Enable UHCI on S3 and C3 #4011 [bugadani]

    It helps if the peripheral has a running clock

    • MabezDev: LGTM, did you try c2 by the way? Should be the same block as the C3... though emphasis on the should :D

  • Revisit setting PHY whether in combo module #4015 [JurajSadel] package:esp-radio investigation

    cc #4014 (review), #4003

  • Backtrace tweaks #4012 [bugadani]

    This PR fixes a few things in esp-backtrace and uses esp-metadata(-generated) instead of the duplicate memory range info.

    • bjoernQ: Nice

  • Fix `wifi` examples #4014 [JurajSadel] skip-changelog

    #4003 broke wifi examples (they couldn't connect). This reverts problematic addition. 802.15.4 examples should be...

    • bjoernQ: it's the exact same thing esp-idf does, so it's probably worth to revisit this but having wifi...

  • I2C: Prefer `cfg_if!` over multiple exclusive `#[cfg]` attributes. #2771 [bugadani] peripheral:i2c maintainability

    We are good here, although multiple versions of the same function exist which violates this rule. The solution,...

  • Stable driver: I2C master #2493 [MabezDev] peripheral:i2c api

    As part of #2491, which has more details on driver analysis. esp-hal API-GUIDELINE omissions #2763 #2764 #2765 ...

  • swap the SDA/SCL order in HIL tests (S2/S3) #4018 [playfulFence] skip-changelog

    closes #4002 corresponding change into physical HIL suite has already been done

    • bugadani

  • Swap the order of the SDA/SCL pins on the S2/S3 hil setups #4002 [Dominaezzz] tests chip:esp32s2 chip:esp32s3

    esp-hal/hil-test/src/lib.rs Line 60 in 588140a ...

    • MabezDev: Makes sense, we'll update this soon.

  • Light RTC_IO refactor #4019 [Dominaezzz]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: We should probably start by defining the InputSignal/OutputSignal equivalent. On the S3 there is...

  • Cpu-driven SHA work queue driver #4013 [bugadani]

    • bjoernQ

  • Fix devguide #4020 [bugadani]

    When we renamed Mode to DriverMode, we forgot to update the DEVELOPER-GUIDELINES accordingly

    • bjoernQ

  • [esp-backtrace]: Only halt cores when using the halt-core feature #4010 [SergioGasquez]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bjoernQ: Thanks! No idea how we lost that feature's functionality rg the p4 code, we can probably just...

    • bugadani: There's one problem with looping: interrupts will continue to be services. We should likely...

    • bugadani: Also now custom-halt no longer implies halt-cores, we should document this. Though the different...

    • bugadani: Suggested change ## Invoke the...

    • MabezDev: "imply the"

    • bugadani

  • Review `wifi` module APIs #3958 [MabezDev] package:esp-radio

    Using the same lines of questioning as #2491 (comment), we need to analyze and fix and glaring API holes.

  • Split out PHY init into `esp-phy` crate. #3892 [Frostie314159]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • Frostie314159: Hi, sorry for the delay. I'll work on this tomorrow.

    • bjoernQ: There were some changes around the moved code - just FYI

    • Frostie314159: @bjoernQ I'm not quite sure, what's causing the CI failure on the S3. Do you have any ideas?

    • bjoernQ: the idea is to prefix the "extern" functions so they don't likely collide with anything else -...

      • Frostie314159: I actually don't know, why, how and when I changed that. But yeah, that doesn't look right.

      • bjoernQ: np - there are a lot of these changes in multiple files 🤷‍♂️

      • Frostie314159: Ok, I figured it out. I actually intended on deleting those files anyway...

    • Frostie314159: I don't really know how to proceed, regarding the unstable feature, as I don't understand the...

    • bjoernQ: I don't really know how to proceed, regarding the unstable feature, as I don't understand the...

    • bjoernQ: I'm not quite sure, what's causing the CI failure on the S3. Do you have any ideas? Missed...

    • Frostie314159: @bjoernQ Apparently libbtbb.a is not getting linked, for whatever reason.

  • Exception 'Load access fault' #4004 [Szybet] bug

    Bug description Every few days, while booting my program, this happens just after turning on BLE: 5.848220 [INFO ]...

    • MabezDev: What's on line init-esp32-c6/src/main.rs:43:5?

    • Szybet: #[defmt::panic_handler] fn panic() -> ! { core::panic!("panic via `defmt::panic!`") } The...

    • bjoernQ: would be really good to have a somewhat reliable reproducer for this - given I haven't seen this...

    • Szybet: Well it's not reliable to reproduce in my program (Maybe would be if probe-rs attach wouldn't...

  • Allow the `esp-wifi` stack to run on the 2nd core #2447 [ProfFan] package:esp-radio

    Motivations This would allow for more predictable timings for real-time tasks on the 1st core (as it is the...

    • jessebraham: Based on my testing, both the ble/scanner and wifi/dhcp examples seem to run correctly on either...

  • Select example if none was specified #4024 [bugadani]

    This PR makes cargo xtask run example work

    • playfulFence

  • sdio: initial SDIO HAL implementation #3503 [rmsyn]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

  • Make internals private #4029 [bjoernQ]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani

  • Use div_ceil for buffer size calculation #4022 [FernandoPerezLara] skip-changelog

    Submission Checklist 📝 I have updated existing examples or added new ones (if applicable). I have used cargo...

    • Dominaezzz: Wouldn't say this is strictly necessary but it doesn't hurt

      • FernandoPerezLara: It's not necessary at all, but the problem is that if you use Clippy in your project to check...

      • bugadani: What Dominic says is that the changelog isn't necessary

      • FernandoPerezLara: Oh great, sorry for the misunderstanding.

    • bugadani: I guess these need to be ($size as usize).div_ceil(4)

      • FernandoPerezLara: Right, changed, thanks!

    • bugadani: Thank you!

  • General esp-radio cleanup #4017 [JurajSadel]

    Progress towards #3964 What's not touched here from the list: matter of taste: the config module with just one enum...

    • bjoernQ: fields shouldn't be public if we derive BuilderLite - we want to force users to go through the...

    • MabezDev

      • MabezDev: I would probably invert this flag to be #[builder_lite(ref)] meaning the getter is a reference

        • JurajSadel: ref is keyword, I used reference instead.

      • MabezDev: Why aren't the protocols part of the config?

        • bjoernQ: AccessPointConfig contains it but it's not honored currently 🙃 We can add the protocol to all...

    • jessebraham

      • jessebraham: Nitpick, but I don't think there's any reason for this function to exist (unless I've missed...

        • JurajSadel: True, thanks!

      • jessebraham: Same as above.

    • bjoernQ: oh I didn't notice RxControlInfo is also re-used by esp-now ... interesting

    • bjoernQ: that comment doesn't make sense - set_config sets the wifi-mode

    • bjoernQ: this is good but I guess we need sta_state/ap_state to be stable - w/o a way to retrieve the...

    • bjoernQ: given it's also used by esp-now we need to adapt the cfg-gate

    • bjoernQ: if this file gets compiled the feature esp-now is active - we can remove the cfg-gate here

    • AnthonyGrondin: should we move sta_mac/ap_mac to the interfaces? There's already the mac_address() helper to...

    • bjoernQ: should we move sta_mac/ap_mac to the interfaces? There's already the mac_address() helper to...

    • bjoernQ: We will need a few more iterations so let's progress

    • bugadani

  • Building examples fails. #4032 [Firstyear] bug status:needs-attention

    Bug description Following the instructions from...

    • Firstyear: In fact, following the README here, https://github.com/esp-rs/esp-hal/tree/main/examples I can't...

    • bjoernQ: Out documentation doesn't mention to cargo install cargo-xtask - this is the important...

    • Firstyear: The readme states As previously stated, we use the...

    • bjoernQ: Well the link doesn't instruct you to run cargo install cargo-xtask - it explains the pattern...

    • Firstyear: Do you think maybe that the readme should list or say "DO NOT INSTALL" this? From the view of a...

    • bjoernQ: Do you think maybe that the readme should list or say "DO NOT INSTALL" this? From the view of a...

    • Firstyear: yes. Which is why I installed it. So instead, don't talk about the external tool at all. Just...

  • Don't talk too much about xtasks #4034 [bjoernQ] skip-changelog

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • JurajSadel

    • bugadani: I think we need to be more clear about needing to clone the entire repo to run examples. But now...

    • bjoernQ: I think we need to be more clear about needing to clone the entire repo to run examples. But now...

  • ESP32-S3: Add RtcI2c driver #4016 [Dominaezzz]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: These shouldn't be hidden, the documentation should show the user which pins implement these traits.

      • Dominaezzz: Ah, OtgFs does the same thing, so I followed suit. I'll change this one at least.

    • bugadani: Any chance this could be common with the LP_I2C in C6?

    • Dominaezzz: Any chance this could be common with the LP_I2C in C6? I'm afraid the hardware (and APIs) is...

    • Dominaezzz: Any ideas why for_each_analog_function doesn't work? By "Not working", I mean no code is being emitted.

    • bugadani: Because these SAR_I2C_* signals are in for_each_lp_function

    • bugadani: Could be, this is the first time I've seen RTC_I2C. (I stand corrected LOL, I just forgot about...

    • bugadani: If you get to this, prefer outer comments in rtc.rs, don't document the module here 😅

      • Dominaezzz: Whoops, forgot that TODO. Ahhh so that's why lp_i2c was fine but rtc wasn't.

    • bugadani: I'm a bit torn here, IMHO we should stick to the with_sda/with_scl functions. OTG-FS is not the...

      • Dominaezzz: I did try separate functions for the pins, but the hardware stops working if the pins aren't...

    • bugadani: This would look soooooooo much better as a builder pattern, this is just a random list of...

      • bugadani: Oh yeah I remember what happened here. We don't provide a const default constructor in...

      • Dominaezzz: I've opted to drop the consts for now. We can re-add it later if needed.

    • bugadani: I think I mucked up the S3 metadata (it sets RTC_I2C as function 1), but I'm not entirely sure...

      • Dominaezzz: I suppose you're picturing something similar to this? ...

      • bugadani: Yeah I'd probably do the same (as in, I'd go for enum RtcFunction/LpFunction), as part of...

    • bugadani: cc #4018

    • bugadani: This is looking pretty nice, let's hope the hardware is a bit less moody than the main I2C....

    • Dominaezzz: I've made a hill test. I can delete the QA test, I only left it there because i2c also has a QA...

    • bugadani: That's unfortunate... Could you add this limitation to the driver's overview section?

  • Random findings for `esp-radio` #3964 [bjoernQ] package:esp-radio

    matter of taste: the config module with just one enum looks a bit out of place wifi_set_log_verbose could get marked...

    • bjoernQ: Some output from Gemini Final Consolidated Recommendations I have now completed a full...

    • bjoernQ: Overuse of enumset in some places I had a look: Enums which are EnumSetType but...

    • bjoernQ: Next round: AccessPointConfig contains protocols - they are not used so we need to either...

    • jessebraham: Another minor point, some configuration structs use Config while others use Configuration,...

    • bjoernQ: A bit more set_protocol -> the wifi-mode needs to be set first - i.e. after set_configuration...

    • playfulFence: I will take a look into last "round" of Björn's findings 👍🏼

  • wifi examples need unpublished crate #4030 [joshmarinacci] bug

    Bug description The new wifi examples need the esp-radio crate, but it is is not published yet. To Reproduce For...

    • joshmarinacci: The dhcp example also needs esp_preempt.

    • bugadani: Yes, examples on the main branch assume the crates come from the main branch of this repository....

    • joshmarinacci: Are there plans to publish the esp-wifi crate in the future?

    • bjoernQ: As said for the latest released version you want to look here:...

  • Usb examples dont work on esp32c6 #4033 [Firstyear] bug status:needs-attention

    Bug description The esp32c6 has a USB port but...

    • Firstyear: https://docs.espressif.com/projects/esp-idf/en/stable/esp32c6/api-guides/usb-serial-jtag-console.html

    • bjoernQ: Probably the problem is what you already described in your other issue, see #4032 (comment)

    • bugadani: Use the example from...

  • Remove esp-backtrace from hil tests #4035 [bugadani]

    In the HIL tests, embedded-test acts as the panic handler. Since we no longer need esp-backtrace to handle...

    • SergioGasquez: LGTM! Although the C2 error is new?

    • bugadani: (11) Transaction completed with First(Err(AcknowledgeCheckFailed(Unknown))) Hardly relevant.

  • Try to fix failing ESP32 test case #4036 [bugadani]

    The previous logic of "assume 200ms is enough for one loop iteration" is probably fine, but rather brittle. The test...

  • Remove dead link in CONTRIBUTING.md #4027 [JurajSadel] skip-changelog

    It was introduced in #1311 and it didn't even work there so I guess we can remove it. Do we want to add a check (CI)...

    • bjoernQ: Given we don't have a document like "Understanding the Project" it's probably best to remove it...

    • JurajSadel: link-checking all MD files and comments in code (Rust and TOML) would be nice I created #4028

    • SergioGasquez: We should also remove the line where the link is defined:...

  • "Understanding the Project" link in CONTRIBUTING.md is broken #4026 [rickymcmuffin]

    In CONTRIBUTING, under New Contributor Guide, the link "Understanding the Project" is broken. It leads to this link:...

  • Clean up the remaining uses of critical sections #3937 [bugadani]

    Motivation: let's remove critical sections from esp-alloc/esp-wifi/esp-println, those are unnecessarily painful on...

  • Introduce esp-sync, avoid critical_section like the plague #4023 [bugadani] skip-changelog

    Closes #3937

    • bjoernQ: Code looks good to me - also ran some hand-picked examples on hand-picked targets just in case...

    • bugadani: Yeah I agree we can do better for that interrupt flag thing. We can store a single counter and a...

  • Add a note regarding running on the second core to `esp-radio` documentation #4037 [jessebraham] skip-changelog

    See title. Feel free to nitpick, wasn't entirely sure what to put, I think I covered the major points at least, but...

    • MabezDev: Let's cfg this section via multi_core cfg (then we can remove the (ESP32 and ESP32-S3 only) references)

  • Move adc channel from associated constant to function #3942 [millibyte-products]

    Motivations Facilitate wrapping pins in a Box<dyn AdcChannel + AnalogPin> structure for runtime pin...

  • RMT: Type-erase channels #3980 [wisp3rwind]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • wisp3rwind: This is ready for review now; HIL failures are unrelated (i2c, the rmt test cases pass). Thanks!

    • bugadani: Can you tell me what the point of the method is, where is it necessary where the const cannot be used?

      • wisp3rwind: The const can always be used; I'm making this change. Having the method must have felt cleaner...

    • bugadani: Commented code - did you mean to remove this, or eventually restore it?

      • wisp3rwind: Good catch ­— this should simply go.

    • MabezDev: Should this and some of the other really be public? Are they needed to be? If they are, these...

      • wisp3rwind: They need to be pub(super) due to being part of the chip_specific sub-module. They're not...

      • MabezDev: Ahh, sorry, I missed that. Thanks for explaining.

    • MabezDev: LGTM, thanks!

  • RMT driver tracking issue #3930 [wisp3rwind] status:long-term peripheral:rmt

    Let's keep track of desirable refactorings and enhancements of the RMT driver. A bunch of these have come up in...

  • Dump global configuration to file #4042 [MabezDev] package:esp-config

    Sparked from #4040 (comment) and some internal discussion with @playfulFence, long term (especially for bug...

  • Add a link-checking for all MD files and comments in code (Rust and TOML) #4028 [JurajSadel] automation

  • esp-alloc - switch from `linked_list_allocator` to `embedded-alloc` #3376 [ivmarkov] package:esp-alloc

    Motivations No particular problem with linked_list_allocator, yet perhaps switching to the embedded-alloc facade...

  • Move semaphore implementation to esp-preempt #4038 [bugadani] skip-changelog

    Proof of concept for #4025. The implementation is still the yield loop we have (without a few bugs we have, like...

    • MabezDev: Can we just unwrap!() these?

    • MabezDev: This is looking great, thank you! I've tested a few wifi/ble examples on a C6 and as expected,...

    • bjoernQ: Maybe we should ask ArielOS (or at least inform them) - back then they were happy to use our...

    • bugadani: Well, they will now be forced :) cc @kaspar030 you should probably know about these changes, we...

  • Move mutexes to esp-preempt #4041 [bugadani] skip-changelog

    cc #4025

  • Improve the UHCI Api, configurable after splitting and dma channel as generic #4039 [Szybet]

    Thank you for your contribution! Submission Checklist 📝 I have updated existing examples or added new ones (if...

    • Dominaezzz

      • Dominaezzz: You don't need the CH generic param, you can do it like you did for Uhci ...

      • Dominaezzz: Same here Suggested change ...

      • Dominaezzz: All the Uhci structs should still have the aaply_config method on them directly. Just like Uart does it.

      • Dominaezzz: Might as well inline this function into apply_config now. Or move it to the read() function as a...

    • Dominaezzz: Maybe that should be noted in the documentation to the apply_config function? I think we can...

  • esp-radio: make compat pluggable #4025 [MabezDev] package:esp-radio

    Similar to #3818, we also need to make the compat primitives pluggable. We need to do this to allow for better...

    • bjoernQ: I guess we need compat/common and compat/timer_compat both pluggable - the timer implementation...

  • Add queue to esp-preempt #4043 [bugadani] skip-changelog

    cc #4025

  • More cleanup in `esp-radio` #4040 [playfulFence]

    A part of #3964. removed config module: PowerSaveMode is a part of wifi module Config structure was...

    • MabezDev

      • MabezDev: This is code I think I wrote, but we need to change it 😅. This will make esp_wifi_sys part of...

      • MabezDev: I wonder if we need this config struct at all? Is there any merit in just using...

        • playfulFence: Done

        • Dominaezzz: Would be nice if users could pass this Config struct in at runtime instead of build time. Some...

    • MabezDev: If the fields are private we don't need to mark this as non_exaustive

      • playfulFence: Similar cases were also fixed in the whole wifi module 👍🏼

    • bjoernQ: LGTM

  • Writing to flash freezes the whole system on ESP32-S3 #4031 [florianL21] bug

    Bug description When trying to write to flash through esp_storage on the ESP32S3 while both cores are active, the...

    • Dominaezzz: You're not allowed to write to flash whilst the other core is executing from it. You have to...

    • florianL21: Is this documented somewhere and I missed it? I also have an example where I park the second...

    • florianL21: Also, if this is the case why does it not freeze if I get rid of the WIFI stack on the first...

    • bjoernQ: Is this documented somewhere and I missed it? Seems it's not yet and it should get added to the...

    • florianL21: I see. That seems logical. But this raises another question for me: If I am supposed to park the...

    • bugadani: Ideally we should solve this inside esp-storage. Unfortunately, that is hard to do generally -...

    • florianL21: Just to be very clear, the park_core call returning before the core is actually parked was just...

    • Dominaezzz: In general I am a bit surprised to see such behavior as neither of the two APIs I am using...

    • florianL21: Strictly speaking, unsafe has to do with rust rules being broken, not necessarily the hardware...

    • bjoernQ: I tried to reproduce the part about park_core not parking the core immediately and cannot...

    • florianL21: Well, I just spent 2h on this and I cannot reproduce it either. You probably have already...

  • Add Config structure for I2s #3985 [funmaker]

    Submission Checklist 📝 I have updated existing examples or added new ones (if applicable). I have used cargo...

    • bjoernQ: typo "World" vs "Word"

    • bjoernQ: any reason to not match on config?

      • funmaker: Oh, I had no idea you can use consts as patterns.

    • bugadani: Why is this public if configure just panics if a value other than the 4 presets are used?...

      • funmaker: It only panics on esp32 and esp32s2 where TDM is not supported. This method is not available on...

    • funmaker: I think it might be ready for review now. I will do some more local testing with esp32s3 but I...

    • Dominaezzz: LGTM, it's just missing a apply_config function. The HIL test might be unrelated but the test...

    • bugadani: The HIL test is an unrelated timing issue, resolved swept under the rug by #4036

    • funmaker: I can add apply_config function to the I2s for sake of completeness, but I wonder if it really...

    • Dominaezzz: but maybe I could also add apply_config(UnitConfig) to I2sTx/I2sRx Yes, this is more/less what...

    • funmaker: Ready for review

created at 2025-09-04 01:47 by dinghy 0.13.1.