Activity since 2025-05-29

• esp-rs/esp-hal repo issues and pull requests

  • Add i2c blocking timeout test, unwrap results #3567 [bugadani]

    • MabezDev

  • use 1.87 in CI, bump MSRV to 1.86 #3560 [MabezDev] skip-changelog

    MSRV bump is for #3105 I added skip-changelog label, however I'm not sure if this is correct. I can add "Bumped...

    • bugadani

  • Change common test pins for esp32 #3573 [playfulFence] skip-changelog tests

    Context: @bugadani asked us to change the pins used in esp32 HIL runner, because previous GPIO26-GPIO27 was...

    • bugadani: Thanks <3

    • JurajSadel

  • I2c: clear bus on error #3570 [bugadani] skip-changelog

    This PR implements (among others) s_i2c_master_clear_bus from esp-idf, and is meant to ensure that upon an error,...

    • copilot-pull-request-reviewer: Pull Request Overview This pull request enhances the I2C master driver by implementing a clear...

      • copilot-pull-request-reviewer: Consider replacing the hardcoded magic number '9' for clock pulses with a named constant to...

      • copilot-pull-request-reviewer: [nitpick] Review the configuration update in apply_config to ensure that directly copying the...

    • MabezDev: LGTM, thanks!

      • MabezDev: Not for this PR, but maybe we want to start leveraging the cfg symbols we can make into "quirk"...

        • bugadani: I'm still wishing for peripheral versions but given that we have differences between devices...

        • MabezDev: Ah yes, I forgot about your versioned peripheral idea! That might also come in handy soon. We...

    • bjoernQ: LGTM

  • Disable timer as part of preempt::disable #3575 [bugadani] skip-changelog

    Implements #3553 (comment)

    • bjoernQ

    • MabezDev: Thanks!

  • Summarize failed CI checks #3574 [bjoernQ] skip-changelog

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • MabezDev: Thanks!

    • SergioGasquez: Nice improvement, thanks!

  • I2C tweaks #3552 [bugadani] skip-changelog

    This PR tweaks the I2C driver in the following ways: I2cFuture is now implemented for ESP32, although it busy-wakes...

  • Tweak I2cFuture #3571 [bugadani] skip-changelog

    This PR refactors ESP32 to use the I2cFuture code, and adds soft timeout for ESP32-S2. This allows re-enabling the...

    • bugadani: I'll changelog this when we have the ability to configure the software timeout (in #3577 )

    • MabezDev: LGTM, I was gunna mention that we have all the pieces for the drop impl TODO, but I see you've...

    • bjoernQ: LGTM

  • Fix ESP32 MAC address from efuse #3579 [bjoernQ] skip-changelog

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bjoernQ: Fixes #3578 skip-changelog since we introduced the bug in the current iteration

    • bugadani: For reference, esp32/esp_efuse_table.csv contains the following: MAC, ...

    • bjoernQ: Not sure if we should wait for the corresponding PR in esp-flash

    • MabezDev: Thanks!

  • ESP32: `wifi_dhcp` example unable to connect to AP #3578 [bjoernQ] bug package:esp-wifi

    Bisect: 63ed40c3684db6ecbae37eade5cd620061788812 is the first bad commit commit...

    • bjoernQ: See #3440

    • MabezDev: I think I saw a comment somewhere (I can't find it now), but I think this line might be the...

  • Simplify esp-wifi timer code #3576 [bugadani] skip-changelog

    This PR moves architecture-independent code from the architecture-specific modules up a level.

    • bugadani: It's a good thing we don't have multicore risc-v chips with radio, this would conflict with...

      • MabezDev: The annoyance with this whole thing is that we can't be smart about reserving them (at least I...

      • bugadani: Technically, we can. esp-hal-embassy already uses an intended-to-be-private feature to grab...

      • MabezDev: Oops, something something, off by one :D. I forgot about that, I guess private features are the...

      • bugadani: I'll add that to this PR unless I'm delayed a bit :) we can reserve for risc-v only with...

      • bugadani: Done; I still wonder if we should just use FROM_CPU_INT2 on all architectures, but at least now...

      • Dominaezzz: Goodness, these private reservations are getting out of hand. Can the interrupt be taken in the...

      • MabezDev: At this rate anyone who simply adds esp-wifi as a dependency loses two interrupts, whether or...

      • bugadani: It's not even random stuff, it's a) architecture and feature-dependent and b) it's fixed so...

      • bugadani: We could tweak esp-wifi a bit, and require the user to initialize and pass in the scheduler....

      • Dominaezzz: esp-wifi because init will now require something to be passed in to reserve it My point was one...

    • bugadani: This was removed just because Xtensa doesn't have it. Maybe we should restart the timer on a...

    • bjoernQ: Looks good to me

    • MabezDev: Thanks!

  • [esp-wifi]: Expose and wrap `esp_wifi_sta_get_rssi()` to get the RSSI of the currently connected Station. #3580 [AnthonyGrondin]

    Motivations Currently, the RSSI info can be obtained from performing a scan, in AccessPointInfo, but there's no way...

  • Fix `Instant::duration_since_epoch` #3582 [bugadani]

    🤦🏻

    • MabezDev: Oops 😅

    • bjoernQ

    • MabezDev: esp32 just failed in test test::run_thread_executor_test_on_core_1 so I pulled it from the queue

    • bugadani: esp32 spuriously fails all the time

  • Fix i2c hanging after cancelling a transaction #3572 [bugadani] skip-changelog

    • MabezDev: LGTM

    • bjoernQ: LGTM

  • Improve PSRAM detection #3554 [bjoernQ]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • playfulFence: @MabezDev Will be done

    • bjoernQ: "undraft" - no idea why I'm so unlucky in running the run_thread_executor_test_on_core_1 test on...

    • bugadani

    • MabezDev

  • Improve PSRAM/OPSRAM error reporting #2591 [MabezDev] peripheral:psram

    Spawning from #2546 (comment) when no PSRAM is available (or unable to talk to it) it seems it will just pretend...

  • Remove note about fixed cargo bug #3105 [bugadani] skip-changelog

    rust-lang/cargo#10358 has been fixed, we probably no longer want to call it out. The fix will be part of 1.86, so we...

    • MabezDev: Thank you!

    • bjoernQ: LGTM

  • I2c: software timeout #3577 [bugadani]

    This PR adds a software timeout feature, primarily to work around the lack of (functional) FSM timeouts in ESP32/S2.

    • MabezDev: I know its draft :D, but some initial comments

      • MabezDev: Is this TODO still relevant, now that we can configure a software timeout?

      • MabezDev: These impls probably deserve a changelog entry

    • MabezDev: LGTM, thanks!

    • bjoernQ: Thanks

    • playfulFence: I like the changes, thanks!

  • Add docsrs metadata and warning for esp-lp-hal #3587 [MabezDev] skip-changelog

    Testing I built once with cargo docs-rs --open to show the notice, then again with our xtask tooling to prove the...

    • bugadani

    • bjoernQ: 👍

  • Prepare releases #3586 [MabezDev] skip-changelog release-pr

    This pull request prepares the following packages for release: xtensa-lx-rt-proc-macros: 0.3.0 esp-hal-procmacros:...

    • MabezDev: Notes from my side: The tooling correctly detected that we need an esp-lp-hal release, however...

    • MabezDev: The xtensa-* packages have no changes, but we bumped the MSRV, so I suppose it's still worth the release?

    • bugadani: The xtensa-* packages have no changes, but we bumped the MSRV, so I suppose it's still worth the...

  • Test #3584 [bugadani] skip-changelog

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

  • Prepare release #3588 [MabezDev] skip-changelog release-pr

    This pull request prepares the following packages for release: esp-build: 0.3.0 xtensa-lx:...

    • copilot-pull-request-reviewer: Pull Request Overview This pull request prepares multiple ESP packages for an upcoming release...

    • bjoernQ: Release automation seems to make a very good job so far! Nice to see

    • bugadani

    • SergioGasquez: A bit late to the party, but copilot pointed this typo Suggested change ...

      • bugadani: It's not important enough to cancel the process, we can retcon it. That it's not fixed in the...

  • xtask: publish can fail on certain crates #3590 [MabezDev] automation

    The current logic for publishing is too naive, it only assumes that if a package has chip features then it can't be...

  • Broken documentation build for esp-lp-hal on docs.rs #2879 [Be-ing] documentation package:esp-lp-hal

    esp-lp-hal has no documentation on https://docs.rs/crate/esp-lp-hal/latest because the build...

    • MabezDev: Closed via #3587

    • MabezDev: https://docs.rs/esp-lp-hal/latest/esp_lp_hal/

  • self hosted docs: ${project}/latest returns 500 internal error #3592 [MabezDev] documentation

    • bugadani: For reference, https://docs.espressif.com/projects/rust/esp-wifi/latest/ (as is the link on...

  • feat(esp-wifi): Add fetching RSSI by wrapping `esp_wifi_sta_get_rssi()` #3593 [AnthonyGrondin]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • playfulFence: Is it possible to use some kind of code restriction instead of "just" a warning in the...

      • AnthonyGrondin: Fixed in 511073b That was a good check because esp_wifi_sta_get_rssi() returns ESP_FAIL (-1)...

    • bugadani: Please don't edit the changelog of a released version.

      • AnthonyGrondin: Yeah, a new version was released while I pushed this. I'm gonna need to rebase

    • playfulFence: Thank you, my concerns have been addressed!

  • sdio: initial SDIO HAL implementation #3503 [rmsyn]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • rmsyn: Running the CI / * checks are failing, partially due to some weird dependency resolution. As I...

    • bugadani: It would be best to not block this PR on embedded-hal, as it'll likely take months to stabilize...

    • MabezDev: To expand on @bugadani's comment, we can't merge this with git dependencies, so I would take the...

    • rmsyn: It would be best to not block this PR on embedded-hal, as it'll likely take months to stabilize...

  • RMT: Refactor driver internals (less macros, type-erased channels) #3505 [wisp3rwind]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

  • Revisit ESP32-S2 SVD's SPI0 / SPI1 definitions #3583 [bjoernQ] chip:esp32s2

    The SVD treats all SPIs the same while in reality SPI0/SPI1 are MEM-SPI and others are GP-SPI. They have some things...

  • esp-wifi: Fix ble + coex + defmt for ESP32 #3596 [bjoernQ]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • JurajSadel

    • MabezDev: Thanks!

  • Lint with DEFMT_LOG=trace #3595 [bugadani]

    Let's see if this catches our mistake Nope, we have lints goofed up, but still this will be needed I think.

    • playfulFence

    • SergioGasquez

  • S2: Allow configuring `BusTimeout::Disabled` #3591 [bugadani]

    The S2 timeout register has an enable bit, similar to later chips, so we should probably allow disabling the timeout...

    • bjoernQ: if it works, it works

    • JurajSadel

  • Multi-core: Lower the probability of a multi-core executor lockup #3589 [bugadani]

    This should fix HIL. Ideally we'd turn FROM_CPU3 into an edge-triggered interrupt but I couldn't figure out how to...

    • bjoernQ: 👀

    • Dominaezzz: I don't know if this is the same or separate issue but I think this wait_impl implementation is...

      • bugadani: Fun question! I don't think we codegen any critical sections for an atomic <=32bit load, though.

      • Dominaezzz: Ah I see, does that also mean portable-atomic doesn't do it either? In the esp-hal Cargo.toml ,...

      • bugadani: I'm not sure of the entire mechanism that causes it, but here's the generated code for S2, you...

      • Dominaezzz: Ah I see, thanks for checking!

  • Remove global wifi/ble init state tracking #3553 [bjoernQ]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bjoernQ: I'm also curious how esp-idf handles this. I think the drivers already keep track of their own...

    • bugadani: +1 but we likely want to do a patch release before merging this, and then the...

  • Document the I2C module #3594 [bugadani] skip-changelog

    Because when it comes to documentation, we can always do better.

    • bjoernQ: Nice improvement

    • JurajSadel

    • SergioGasquez: Thanks! Left 2 nitpick comments:

      • SergioGasquez: We could actually change a configuration as an example

      • SergioGasquez: Is this a copy paste leftover?

  • I2C infinite loops if the fifo receives less data than expected #3314 [ajwock] bug

    Bug description You're probably thinking what I was thinking- how is that possible? I don't know either, but I do...

    • bugadani: Your example seems to run just fine with esp-hal 1.0.0-beta.1, but I'll test it more since you...

  • Define configs in YAML files #3504 [bjoernQ] skip-changelog

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • MabezDev: i128 was intentional, why do we need to change it?

      • bjoernQ: We could try to PR the YAML lib to support i128 Or in (what I expect to be a rare) case we need...

    • bugadani: I'd still prefer adding i128 support to whatever yaml library we pick - which probably shouldn't...

    • bjoernQ: I'd still prefer adding i128 support to whatever yaml library we pick - which probably shouldn't...

    • bugadani: I'd probably give https://crates.io/crates/facet-yaml a try, Amos tends to write good software...

    • bjoernQ: I'd probably give https://crates.io/crates/facet-yaml a try, Amos tends to write good software...

  • RMT: Extend tx and rx capabilities and API #3509 [wisp3rwind]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

  • Add multi-core critical section test #3585 [bugadani]

    • Dominaezzz: LGTM, just two nits

      • Dominaezzz: You don't need mk_static on these ones right? Just a non-mut static would work

        • bugadani: good spot

      • Dominaezzz: Suggested change use...

    • Dominaezzz

      • Dominaezzz: Suggested change ...

      • Dominaezzz: Suggested change while...

      • Dominaezzz: Suggested change fn...

created at 2025-06-05 02:01 by dinghy 0.13.1.