Activity since 2025-12-08

• esp-rs/esp-hal repo issues and pull requests

  • RMT: Remove generic data types #4616 [wisp3rwind] trusted-author

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: Thank you :)

  • Define esp-hal using ~ inside esp-* crates that depend on unstable features #4621 [bjoernQ] skip-changelog

    Closes #4594 Besides doing that the linked issue asks for it also teaches the xtask to keep the tilde. (And also...

    • JurajSadel: Thanks!

    • MabezDev

  • UART: stabilize `read_ready` and `write_ready` #4600 [bugadani]

    These functions are simple, they are required to work with UART in a guaranteed-nonblocking way, and they are...

    • copilot-pull-request-reviewer: Pull request overview This PR stabilizes the read_ready and write_ready methods on the Uart...

    • bjoernQ: I agree these are simple and useful enough to stabilize them

    • MabezDev: Thanks!

  • Find a way how(and when) to regenerate the baselines automatically #4619 [JurajSadel] CI automation

    Currently, uploaded esp-hal baselines are for esp-hal@rc.0 - we need to find a way how to automate the process so we...

  • The binary-size workflow issues #4628 [bjoernQ] bug CI

    The binary-size workflow has a few issues: Changes to .stack are counted, so total RAM use contributes ~0 to the...

  • ADC Calibration #326 [sourcebox] peripheral:adc

    On ESP32-S3 with an attenuation of 11dB, the readings saturate at about 1.5V. I have a correcttly working project...

  • Implement support for light-/deep-sleep #375 [jessebraham] low power status:long-term

    We should provide APIs for entering light-/deep-sleep. Chips which have been prioritized by the maintainers have...

  • GPIO20 (on esp32-pico-mini-02) commented out #4507 [Colonial-Dev] bug RFC

    Bug description I have an Adafruit ESP32 Feather V2 (an esp32-pico-mini-02), which ties I2C SCL to GPIO 20....

  • Resolve smoltcp#1010 #3825 [MabezDev]

    If we don't resolve smoltcp-rs/smoltcp#1010 we will have a lot of smoltcp features until it's 1.0 release.

  • Implement remaining peripheral drivers for `esp-lp-hal` #1030 [jessebraham] low power status:long-term package:esp-lp-hal

    ESP32-C6 Interrupts LP_I2C LP_IO LP_TIMER LP_UART LP_WDT (?) ESP32-S2/S3 Interrupts RTC_I2C RTC_IO SENS

  • `async` ADC read #1643 [jounathaen] help wanted peripheral:adc

    esp32 esp32s2 esp32s3 esp32c2 - #3082 esp32c3 - #2925 esp32c6 - #2925 esp32h2 - #3082

  • Shutdown the WiFi subsystem gracefully dynamically #4632 [bugadani]

    Discussed in #4631 Originally posted by renkenono December 8, 2025 Hi, I'm working on a project where WiFi is...

  • rtc.time_since_boot() increments 1.158x faster than Instant.elapsed() #4624 [brezina1] bug

    Bug description As the title says - rtc.time_since_boot() is 1.158x larger than Instant.elapsed() over the same...

    • bugadani: Here are the relevant parts of the C3 TRM, which indicate it's not possible to use the same...

    • brezina1: I will use the time_since_boot() to measure critical time operations instead, thank you 😊

  • Release checking with a private registry #4532 [MabezDev] RFC automation api investigation

    There are a number of reasons we want to do this: To do full semver checking (including unstable items) to prevent...

    • bjoernQ: I might have an idea to do this in a more lightweight way (w/o docker and w/o a full-fledged...

  • RMT driver sends one extra pulse on first continuous transmission according to PCNT #4622 [Luro02] bug

    Bug description The code uses the PCNT peripheral to count how many pulses have been sent out. If another pin is...

    • wisp3rwind: Can you verify whether .with_idle_output(true) fixes this? That should be required to make the...

    • wisp3rwind: Maybe, it could also be related to the clock divider issue discussed here: #3930 (comment) I'm...

    • Luro02: Thank you, it really was the idle_output: false. I was sure that I tested it with idle_output:...

    • wisp3rwind: I was sure that I tested it with idle_output: true, but it looks like I didn't. When looking at...

    • Luro02: The ESP-IDF code unconditionally sets the idle_out_en() to true,...

  • Atomic operations in PSRAM (esp. with 3rd party libraries) #2027 [ProfFan] status:blocked upstream peripheral:psram

    AFAIK the current atomic operations on the S3 uses native atomics. However this creates a problem: a 3rd party...

  • qa-test: clean up emojis #4635 [JurajSadel] skip-changelog

    • SergioGasquez

  • RMT: Tentative timing fix/workaround #4637 [wisp3rwind] trusted-author

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • github-actions: [HIL trust list] Trusted users for this PR (click to expand) @wisp3rwind

    • github-actions: Author @wisp3rwind was trusted for this PR via the trusted-author label. They can now use /hil...

    • wisp3rwind: /hil full

    • github-actions: Triggered full HIL run for #4637. Run:...

  • Ensure async waker code lives in IRAM #4627 [bugadani]

    This PR adds #[inline] attributes to lock code to ensure it gets all inlined, and replaces the #[inline] inserted by...

    • copilot-pull-request-reviewer: Pull request overview This PR optimizes interrupt handler performance by ensuring async waker...

    • bjoernQ: /test-size

    • github-actions: Binary Size Report esp32 sleep-timer Diff (PR vs. Base) FILE SIZE VM SIZE ...

    • bugadani: The binary-size workflow has a few issues that I see, regardless of this PR's effects: Changes...

    • bugadani: /hil full

    • github-actions: Triggered full HIL run for #4627. Run:...

    • MabezDev: Whilst the benefit is minimal in the benchmark, I imagine this is because there isn't much cache...

    • bjoernQ

    • bugadani: /hil full

    • github-actions: Triggered full HIL run for #4627. Run:...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 4 out of 4 changed files in this pull request and...

  • RMT driver tracking issue #3930 [wisp3rwind] status:long-term peripheral:rmt

    Let's keep track of desirable refactorings and enhancements of the RMT driver. A bunch of these have come up in...

    • wisp3rwind: In case I didn’t make this clear: configuring a custom clock source is more complex than just...

  • Clock tree rework tracking issue #4502 [bugadani]

    This issue tracks the state of the clock tree rework. #4501 Model clock trees of other chips #4517 #4527 ...

  • xtask docs: Resolve `latest` better #4411 [playfulFence]

    • MabezDev: I'll take care of the nginx changes first.

  • wifi module split #4362 [MabezDev] package:esp-radio

    Currently it's a bit of a jumble of items with no real organization: I don't have precise ideas on how to organize...

    • jessebraham: There is still probably some cleanup left to do, and not all types have a clear location which...

  • Add support for Ext1WakeupSource on H2 #4641 [petuzk]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: pd_top is already part of PowerDownFlags, why did you need to add another field? 🤔

      • petuzk: All PowerDownFlags default to false, and are force-set to true for deep sleep in...

      • bugadani: All PowerDownFlags default to false, and are force-set to true for deep sleep So what if you...

      • petuzk: Because RtcSleepConfig, PowerDownFlags and Rtc::sleep are all public, I suppose the intent is to...

      • bugadani: I wouldn't worry about custom user configuration accidentally ending up wrong. If I start with...

      • petuzk: Okay, I see your point. But then how important is the consistency with C6 which currently has...

      • bugadani: Good point, I don't remember why I wrote that the way I did. Okay, let's leave the current code...

    • bugadani

  • C6: Set highest MSPI divider #4642 [bugadani] skip-changelog

    Fixes #4638 Also resolves an ESP32 todo item. cc #4502

    • bugadani: /hil esp32 esp32c6

    • copilot-pull-request-reviewer: Pull request overview This PR addresses ESP32-C6 MSPI clock configuration by setting the correct...

    • github-actions: Triggered HIL run for #4642 (chips: esp32 esp32c6). Run:...

    • MabezDev: Triggered HIL run for #4642 (chips: esp32 esp32c6). Run:...

    • bugadani: We set the MSPI divider after the upstream clocks, and the initial clock config is unknown, so...

      • MabezDev: If we run a risk of overclocking the flash, could we add an assert to prevent the clocks being...

      • bugadani: I don't think we can add asserts, assuming things about any possible hardware is difficult. The...

    • MabezDev

  • docs(rtc): Mention in the `time_since_boot()` that the timer is reset … #4630 [JurajSadel]

    …on a power-on-reset cc #4623 Not sure if we want to close it or not.

    • bjoernQ: Maybe "Get time since last power-up reset"

    • bjoernQ: maybe we should rename the function, too e.g. time_since_power_up ???

    • MabezDev: LGTM, thanks!

  • Shutdown the WiFi subsystem gracefully dynamically #4639 [renkenono] bug

    Bug description Discussion initially documented in #4631 To Reproduce See...

    • bugadani: Thanks for the reproducers. I've tested the Drop one on esp-hal 1.0, and updated it (source...

  • Proposal to improve changelog handling #4618 [bugadani] RFC

    Currently, the keeping changelogs causes some minor, but nontrivial friction: Even trivial changes require a...

    • tom-borcin: Please read this RFC and leave your comments here

    • SergioGasquez: One potential drawback might be that we don't have a very easy way to see what is already there...

    • bugadani: Maybe we could have a ci action (using and xtask command) that populates the changelog.md file...

    • MabezDev: I'm not bothered whether we track the changes in tree or not, but I'm concerned about things...

    • bugadani: I think there is still value in having the PR number associated with the changelog, could we...

    • MabezDev: That will be the responsibility of the reviewer and the PR author together (because we don't...

    • bugadani: Sure why not

  • xtask refactoring #3170 [MabezDev] CI automation

    This is somewhat of a stub issue which we'll likely want to expand and split up. The xtask has grown organically...

    • MabezDev: A lot of the xtask internals have been refactored since this issue creation, and given that most...

  • Rtc.time_since_boot() does not describe what it actually returns #4623 [brezina1] bug

    Bug description Time since boot (rtc.time_since_boot()) accumulates across reboots/reflashes/hardware reset. The...

    • bugadani: This is technically working as intended, but we should probably make it more clear that the...

    • brezina1: Ah I see, just an unfortunate name then :)

    • MabezDev: I think this is worth keeping around as a documentation issue/future API improvement.

    • MabezDev: Closed via #4630

  • Change issue template labels #4645 [tom-borcin]

    Pull Request Details 📖 Description Changing needs attention label to bug jury for both bug and feature request...

    • copilot-pull-request-reviewer: Pull request overview This PR updates GitHub issue template labels to standardize the project's...

      • copilot-pull-request-reviewer: The label "bug jury" is semantically inappropriate for feature requests. While it may make sense...

    • bugadani: Suggested change - Crate name and...

    • copilot-pull-request-reviewer: Copilot encountered an error and was unable to review this pull request. You can try again by...

    • JurajSadel: Thank you!

  • Exception occurred on ProCpu 'Illegal' when using PSRAM on ESP32s3 #4592 [microidea] bug peripheral:psram

    Bug description PSRAM is detected (start address = 3c020000), but an Illegal exception occurs when...

    • MabezDev: I can reproduce the error by set CPU clock to 240 MHz let config =...

  • add embassy #[main] callback passing #3813 [dragonnn]

    Submission Checklist 📝 I have updated existing examples or added new ones (if applicable). I have used cargo...

    • bugadani: I don't see a point in this, and the callback system either. The executors can no longer affect...

  • Add embassy executor cpu stats #3728 [Szybet]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: I believe rtos-trace offers the required hooks already, either in esp-rtos or in...

  • S3: rework clocktree #4633 [bugadani]

    cc #4502 Includes some cleanups for other chips that should not really make much difference.

    • copilot-pull-request-reviewer: Pull request overview This pull request reworks the clock tree infrastructure for the ESP32-S3...

      • copilot-pull-request-reviewer: The PAC dependencies are pointing to a Git repository with a specific commit revision instead of...

      • copilot-pull-request-reviewer: The chip identifier in this file header comment is incorrect. This is ESP32-S3 clock tree...

      • copilot-pull-request-reviewer: The condition logic is incorrect. The comment states "PVT supported after blk_ver 1.2", but the...

    • bugadani: /hil esp32s3

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 12 out of 13 changed files in this pull request and...

    • github-actions: Triggered HIL run for #4633 (chips: esp32s3). Run:...

    • bugadani: /hil full

    • github-actions: Triggered full HIL run for #4633. Run:...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 12 out of 13 changed files in this pull request and...

    • MabezDev: LGTM + some nitpicks and questions

      • MabezDev: Given internal confusion this caused, could we get a small comment about what PVT is (or at...

        • bugadani: done

      • MabezDev: Just for my curiosity, were we doing this calibration before?

        • bugadani: Not to my knowledge

        • MabezDev: 🤔 seems quite important, I wonder if this sort of thing could have been the cause of random...

        • bugadani: Probably, maybe, but I think the defaults are conservative enough to just waste power.

      • MabezDev: What's the purpose behind this change?

        • bugadani: This just makes my life easier. With this change, the esp_radio test suite now covers the...

  • Feature request: Run single HIL test via slash commands #4640 [wisp3rwind] tests feature request

    Motivations In the spirit of #4429 and #4526, I just thought that it might be useful to be able to kick of HIL runs...

  • Tweak slow clock impls #4629 [bugadani] skip-changelog

    cc #4502

    • copilot-pull-request-reviewer: Pull request overview This PR refines the RC_SLOW_CLK implementations across multiple ESP32...

      • copilot-pull-request-reviewer: The comment mentions "136k clock" but this is actually the RC_SLOW_CLK which operates at 90kHz...

      • copilot-pull-request-reviewer: The en parameter is not being used in this function. The calibration value is set regardless of...

      • copilot-pull-request-reviewer: The en parameter is not being used when setting the calibration value. The calibration is...

      • copilot-pull-request-reviewer: The return values from modify() and write() operations are being assigned to new_value, but...

      • copilot-pull-request-reviewer: The en parameter is not being used in this function. The calibration value and divider are set...

    • bugadani: /hil full

    • github-actions: Triggered full HIL run for #4629. Run:...

    • bugadani: /hil full

    • github-actions: Triggered full HIL run for #4629. Run:...

    • playfulFence: /hil full

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 7 out of 7 changed files in this pull request and...

    • github-actions: Triggered full HIL run for #4629. Run:...

    • bugadani: Just the usual spurious-looking wifi scanner memleak failure.

    • MabezDev: Thanks!

  • Investigate and improve interrupt flag codegen #2987 [bugadani] performance peripheral:interrupt

    Based on #2960 we might have some work to do - for one, we should change the other drivers as well. But we could...

    • bugadani: The following pattern optimizes the enumset loopy-jumpy-bitsetty nonsense away...

  • `state` functions should be removed, mirror async API for events #4364 [MabezDev] RFC package:esp-radio

    They are inherently racey, and I think we should mirror the async API (i.e wait_for_event and friends) for this kind...

    • tom-borcin: Please read this RFC and leave your comments here

  • UART: Multiple GPIOs are accepted as arguments and run the same #4614 [iampi31415] bug

    Bug description A configuration with any GPIO peripheral (6,8 in the example) let mut uart =...

    • tom-borcin: @iampi31415 we reviewed this issue during bug jury meeting and decided to keep it in backlog....

  • xtask: Add `SemVer` checks for `esp-rom-sys` #4584 [JurajSadel] skip-changelog

    This might be a bit of a hacky solution, but I tried to convince cargo-semver-checks that esp-rom-sys is not...

    • MabezDev: If we don't use this code there is no point testing it :D. What we need to do is test the logic...

      • JurajSadel: Oh .. yeah that is complete nonsense 🤕 Should be fixed now

    • MabezDev: This test actually gives some insight to my original request. What does Minor mean here? If the...

      • JurajSadel: It refers to y.

      • MabezDev: Then I think it's wrong, because when it comes to executing the plan we'll bail:...

      • JurajSadel: I might be missing something here but how do we want to deal with breaking changes in...

  • Fix systimer timestamp conversion #4634 [bugadani]

    Perf improvement, improved systimer accuracy on 26MHz C2, one step towards removing Clocks, what else do we need? (a...

    • bugadani: This being insta-stable-and-unchangeable is bothering me

    • copilot-pull-request-reviewer: Pull request overview This PR aims to fix systimer timestamp conversion accuracy and improve...

      • copilot-pull-request-reviewer: Grammar issue: "we'd count return" should be "we'd return" - the word "count" seems to be...

      • copilot-pull-request-reviewer: Critical bug: ticks_per_second() is documented to return ticks per second (Hz), but the...

      • copilot-pull-request-reviewer: Precision loss bug: The uneven divider calculation computes ticks_per_us * UNEVEN_MULTIPLIER...

    • bugadani: I was wondering why the ticks_per_sec change had no effect here, then I saw we multiplied, then...

    • bugadani: /hil full

    • github-actions: Triggered full HIL run for #4634. Run:...

  • Fix clippy lints #4646 [bugadani] skip-changelog

    error: manual implementation of `.is_multiple_of()` --> src\dma\mod.rs:2185:28 | 2185 | ...

    • copilot-pull-request-reviewer: Pull request overview This PR addresses clippy lint warnings by replacing manual modulo-based...

      • copilot-pull-request-reviewer: For consistency with the clippy fix applied to line 1919, this line should also be updated to...

      • copilot-pull-request-reviewer: For consistency with the clippy fix applied to line 2185, this line should also be updated to...

    • JurajSadel

  • Clean up MCPWM clock sources #4647 [bugadani]

  • Try to optimize accessing the current task #4648 [bugadani] skip-changelog

    This PR moves the current task pointer out of the mutex-locked scheduler state. This is safe to do, as explained in...

    • copilot-pull-request-reviewer: Pull request overview This PR optimizes access to the current task pointer by moving it out of...

      • copilot-pull-request-reviewer: The use of Ordering::Relaxed here may not provide sufficient synchronization guarantees when...

      • copilot-pull-request-reviewer: The use of Ordering::Relaxed here may not provide sufficient synchronization guarantees. Since...

      • copilot-pull-request-reviewer: The use of Ordering::Relaxed here may not provide sufficient synchronization guarantees for...

      • copilot-pull-request-reviewer: The function free is defined with pub visibility but is a local function inside the current_task...

      • copilot-pull-request-reviewer: The documentation comment explains the safety rationale for accessing current_task without the...

      • copilot-pull-request-reviewer: The use of Ordering::Relaxed here may not provide sufficient synchronization guarantees. When...

    • bjoernQ

  • esp32c6 not booting since commit d118250c5cf163426d68e1335323e9804c4b1d9e #4638 [nponsard] bug chip:esp32c6

    Bug description I've tried flashing multiple examples from the main branch like embassy_hello_world,...

    • bugadani: Issue title says C2, are you having issues with that one, too?

    • bugadani: Can you provide the output of espflash board-info for all affected boards, please?

    • nponsard: Issue title says C2, are you having issues with that one, too? Sorry that was a mistake, I only...

    • nponsard: XIAO: [2025-12-09T14:48:05Z INFO ] Serial port: '/dev/ttyACM0' [2025-12-09T14:48:05Z INFO ]...

    • bugadani: Thank you! One more thing: have you tried espflash 4.x?

    • nponsard: Just tried with espflash v4.2.0 on both boards with example embassy_hello_world and...

    • nponsard: Running embassy_hello_world_defmt setting DEFMT_LOG = "trace" I get some output from the...

    • bugadani: Thanks for the info. Unfortunately this means that I don't have a good way to reproduce your...

    • nponsard: This seems to fail on my boards: $ cargo xtask run tests esp32c6 --test esp_radio Finished...

    • bugadani: Hmm that's not the error I've expected, your probe-rs may be a bit too old. Anyway thanks for...

    • nponsard: I added debug! statements to try to find where it crashes. It seems to crash somewhere after the...

    • bugadani: Oh that is a very good observation, I may have forgotten about this: // On ESP32C6, MSPI...

    • nponsard: I confirm that this issue is now fixed for my board 👍

  • Minor clock tree tweaks #4636 [bugadani] skip-changelog

    This PR adds the PLL_F160M clock source to ESP32, which is a clock source of the MCPWM and I2S peripherals. This PR...

    • copilot-pull-request-reviewer: Pull request overview This PR enhances the ESP32 clock tree implementation by adding the...

      • copilot-pull-request-reviewer: [nitpick] The spacing after from = "PLL_CLK" is inconsistent with line 123. Consider adding an...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 7 out of 7 changed files in this pull request and...

    • bjoernQ

  • HIL testing depending on what has been changed #4651 [playfulFence] RFC tests

    Once I finish working on #4640, we will have more or less all the "prerequisites" to proceed with further...

    • bugadani: IMHO it's way too hard to do this based on source code reliably, and accurately, just to save a...

  • Use released `esp-wifi-sys-esp32X` packages #4652 [bjoernQ] skip-changelog

    Let's use the released packages

    • MabezDev

    • MabezDev: /hill full

    • github-actions: Usage: /hil quick — run a quick HIL matrix (only ESP32-S3 (Xtensa) and ESP32-C6 (RISC-V)...

    • MabezDev: /hil full

    • github-actions: Triggered full HIL run for #4652. Run:...

    • bjoernQ: I guess the S2 hiccup is unrelated

  • Wifi examples unable to connect on ESP32-S2 #4650 [bjoernQ] bug package:esp-radio chip:esp32s2

    On current main (1d1f402 Wed Dec 10 18:11:31 2025 +0100), both dhcp and embassy_dhcp don't connect to WiFi (or at...

  • S2(clocks): Fix ref_tick divider #4654 [JurajSadel] skip-changelog

    Fix wrong ref_tick divider based on clk_ll_ref_tick_set_divider. With this change the embassy_dhcp and dhcp examples...

    • bugadani: This shouldn't be working, unless the TRM is wrong:

  • multicore + embassy + wifi = broken? #4573 [kevinross]

    Hey all, I'm wondering if it's a known issue where the radio doesn't play nicely when the second core is started?...

    • kevinross: Finally finished refactoring the global statics and wrong usage of spawners, the alloc error has...

  • Inline control of upstream clock nodes #4644 [bugadani]

    This PR inlines the implementation of x_request/release_upstream functions into their call sites. The previous...

    • bugadani: /hil full

    • github-actions: Triggered full HIL run for #4644. Run:...

    • bugadani: /hil full

    • bugadani: /test-size

    • github-actions: Binary Size Report esp32 sleep-timer Diff (PR vs. Base) FILE SIZE VM SIZE ...

    • bugadani: Awesome, this doesn't seem to make much difference in terms of binary size.

    • github-actions: Triggered full HIL run for #4644. Run:...

    • copilot-pull-request-reviewer: Copilot encountered an error and was unable to review this pull request. You can try again by...

      • copilot-pull-request-reviewer: Bug: This should call release_fn_name() instead of request_fn_name(). The impl_release_upstream...

      • copilot-pull-request-reviewer: Bug: These request_* functions are calling release_* functions instead of request_* functions....

      • copilot-pull-request-reviewer: Bug: These request_* functions are calling release_* functions instead of request_* functions....

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 8 out of 8 changed files in this pull request and...

    • MabezDev

  • refactor(rtos): remove unneeded timer handler cast #4653 [kaspar030] skip-changelog

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • kaspar030: Does this need a changelog entry?

    • kaspar030: The build error seems unrelated:...

    • MabezDev: Thanks!

  • `xtask` command to use a local registry #4655 [bjoernQ] skip-changelog

    This explores the idea of #4532 It's using a local registry (in the file system) instead of using a full-fledged...

    • MabezDev: This is really cool! Thanks for experimenting with this. Using local registries is a good idea,...

    • bjoernQ: Can we reuse our current test suite and examples? We have great coverage already, it would be...

  • xtask: Generate pub markers for `esp-rom-sys` ROM symbols for semver checks #4613 [JurajSadel] skip-changelog

    Implements #4490 (comment) This temporarily creates (for all chips) #[cfg(all(feature = "<chip_name>", feature =...

    • bjoernQ: inclusion of the module is already gated by __internal_rom_symbols and you ditched the idea of...

    • bjoernQ: Still not sure about the "parser" - some tests to prove it's working (and keeps working) would...

    • bugadani: Why is : part of the syntax? Is symbol: address; a valid syntax in linker scripts?

      • JurajSadel: Actually, it's not valid so I removed it.

    • bjoernQ: why don't we just get this via Package's semver_feature_rules?

    • bjoernQ: commented code always looks sus ... especially without any additional comment I guess this is...

    • bjoernQ: we could test a bit more here - especially handling of commented out code (and this for example...

  • `read_exact_async` returns `FifoOverflowed` when more than 128 bytes is to be received #4523 [jimy-byerley] bug peripheral:uart

    Bug description In the following example, i program a esp32-none to simply echo on UART1, and my pc to alternatively...

    • bugadani: Were you also using embassy ? Yes i will try to make more experiements with the threshold this...

    • jimy-byerley: I could not improve on my side setting the threshold from esp_hal public API i did let config =...

    • jimy-byerley: could it be that the embassy runtime makes pauses of few milliseconds time to time ? like for...

    • bugadani: I've done most of my previous testing on the ESP32-S3, with probe-rs as the programmer. probe-rs...

    • jimy-byerley: The above code is exactly what i am using 🤔 You can see it in the repo i'm working on do you...

    • tom-borcin: @jimy-byerley we have discussed this issue during bug jury and we are moving it back to backlog....

    • jimy-byerley: ok, thanks for the update I will tell you if i find anything on my side

    • jimy-byerley: I found my problems: 1: I was receiving FifoOverflowed time to time because the threshold set...

  • esp-radio: Hide `wifi_csi_info_t` from pub API #4643 [JurajSadel]

    closes #4585

    • bugadani: Drop the prefix, and document the structure properly, please. Explain its purpose, not its...

    • bugadani: You should spell out destination, header, and sequence I think.

    • bugadani: We will need to attach a lifetime to this struct and callback, as far as I understand the user...

    • bugadani: Also why is there no changelog entry here? Isn't this a user-visible change?

    • MabezDev

      • MabezDev: This seems like an impl detail that shouldn't be exposed?

        • JurajSadel: It is mentioned in the esp-idf docs so I exposed it: If first_word_invalid field of...

        • MabezDev: What does esp-idf do with this info? Does it read and choose not to call the user callback?

      • MabezDev: This can be UB if the size is wrong, so lets nail this down and make it correct. If it is...

        • JurajSadel: I tried to get it experimentally but I'm not 100 % sure, 24 is correct - the header length is...

    • bjoernQ: Returning one of the raw C types defeats the whole purpose of this PR

    • bjoernQ: couldn't we just store the pointer instead of copying it?

    • bjoernQ: You removed this code from the example // Signed bitfields are broken in rust-bingen, see...

      • JurajSadel: Added a comment about this why it's not needed for this use case.

      • bjoernQ: ah - the cast already does the trick since it happend to be 8-bit in that u32 👍

    • bugadani: Why is everything duplicated for the C6?

      • JurajSadel: Because of the WiFi6 - it has different wifi_pkt_rx_ctrl_t or rather esp_wifi_rxctrl_t

      • bugadani: I have a hard time seeing the difference here - the type is the same, there are a bunch of...

  • RMT: Revise Tx error handling and add more HIL tests #4617 [wisp3rwind] trusted-author

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • wisp3rwind: /hil quick

    • github-actions: Triggered quick HIL run for #4617. Run:...

    • wisp3rwind: /hil quick

    • github-actions: Triggered quick HIL run for #4617. Run:...

    • wisp3rwind: /hil esp32 esp32c3 esp32c6

    • github-actions: Triggered HIL run for #4617 (chips: esp32 esp32c3 esp32c6). Run:...

    • wisp3rwind: This should be ready now (HIL failures are due to the c6 runner acting up). Note that I extended...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 3 out of 4 changed files in this pull request and...

      • copilot-pull-request-reviewer: Typo: "writen" should be "write" Suggested change ...

      • copilot-pull-request-reviewer: Typo: "bu" should be "bug" Suggested change ...

      • copilot-pull-request-reviewer: Typo: "occured" should be "occurred" Suggested change ...

      • copilot-pull-request-reviewer: The match arm WriterState::Error(_) => false is unreachable because this code is inside an if...

        • wisp3rwind: needed for exhaustive matching; alternatives would be panicking or unreachable_unchecked, but I...

        • bugadani: there's no need to react to copilots obvious nonsense :)

    • bugadani: This should be expect(unused) or the method should be deleted.

      • wisp3rwind: Removed it for now, this is easy enough to add back if required (I added it originally to expose...

    • bugadani: Indentation is weird, did you mean to include this in the next branch?

      • wisp3rwind: Yes, this belongs to the next branch. I felt like it belongs to the if...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 3 out of 4 changed files in this pull request and...

created at 2025-12-15 02:10 by dinghy 0.13.1.