Activity since 2025-01-09

esp-rs/esp-hal repo issues and pull requests
- UART: The calling order of `with_tx()` and `with_rx()` builder functions might matter #2911 [JurajSadel] bug peripheral:uart status:needs-attention
  let uart = Uart::new(peripherals.UART1, uart::Config::default()) .unwrap() .with_tx(tx) ...
- Document that UART TX should be set up first #2914 [bugadani] skip-changelog
  Resolves #2911 by changing the documentation. The issue is caused by the loopback setup in our tests. When you...
  - bjoernQ: Thanks - makes sense
  - JurajSadel: Thanks!
- GPIO Pin Hold is not supported #2705 [bugadani] peripheral:gpio 1.0 non-breaking
  - MabezDev: While I can imagine to have a FrozenPin driver (name is subject to bike-shedding) the an...
- Always type erase drivers #2572 [MabezDev] 1.0-blocker
  For our drivers we have the option of opting into the new_typed method to create a driver without type erasure, i.e...
- Missing `read_byte` that doesn't use `nb` #2729 [MabezDev] peripheral:uart 1.0-blocker
  - MabezDev: Closing, as we're actually going to remove them instead: #2808
- Remove peripheral instance types #2907 [bugadani] skip-changelog
  Closes #2572 Skip-changelog applied because wifi/embassy previously spelled out AnyTimer.
  - bjoernQ: LGTM
  - MabezDev: LGTM, could you rebase? Let's try and get this in before we get more conflicts 😅
- Should split halves have individual constructors? #2727 [MabezDev] peripheral:uart 1.0 non-breaking
  - bugadani: I suppose (I don't remember) we said this is non-breaking because we intend to mark the split...
- GPIO: Prefer compile-time checks over runtime checks where possible, prefer a fallible API over panics. #2710 [bugadani] peripheral:gpio 1.0-blocker
  AnyPin operations panic when the underlying pin is incompatible. listen_with_options panics with some parameter combinations
- GPIO: wakeup_enable: Return error instead of panic #2916 [bugadani]
  Closes #2710 I guess
  - bjoernQ: LGTM
  - MabezDev: LGTM, thanks!
- Test all feature sets #2901 [bugadani] skip-changelog
  Previously, when a test has multiple //% FEATURES: lines, only one was used. This PR assigns a name to each of those...
  - MabezDev: Thanks!
- Cache bus clock register and support clock source #2897 [bugadani]
  Rough draft of my idea to resolve (eventually) #1666 and #1668 The main idea is to handle clock source and clock...
- Remove more enum prefixes #2922 [bugadani]
  - SergioGasquez: LGTM! Thanks
  - MabezDev: Thanks!
- GPIO unstable items #2693 [MabezDev] peripheral:gpio 1.0-blocker
  We need to mark the following as unstable Unstable modules etm lp_io rtc_io interconnect based on #2492...
- Mark Flex methods as unstable #2917 [bugadani] skip-changelog
  Closes #2693
  - MabezDev: Thanks!
  - bjoernQ: oh - totally missed we can now use the macro on impl blocks 👍
    - bugadani: yes but some care must be taken because the whole impl block is deleted without the unstable feature
  - bjoernQ: LGTM
- [RFC] A time/rate solution #2923 [MabezDev] RFC api 1.0-blocker
  We currently use fugit, which has served us well, and works nicely overall. I do see a few issues with it...
  - bugadani: Well the structure should probably be called Rate or Frequency, as Hertz is a unit of...
  - burrbull: After: https://docs.rs/fugit/latest/fugit/struct.Rate.html#method.kHz
- Do not DerefMut into PAC register blocks #2918 [bugadani] skip-changelog
  This PR is a part of #2661 although that issue needs more work. In the mean time, this PR removes the virtualness...
  - bjoernQ: LGTM
  - JurajSadel: Thanks!
- Add `AcknowledgeCheckFailedReason` #2862 [bjoernQ]
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - jessebraham
  - JurajSadel: Thanks!
- We do not distinguish NACK sources (address/data) which embedded-hal supports. Adding this would change the Error type, most likely renaming the `AckCheckFailed` variant. #2814 [bugadani] peripheral:i2c 1.0-blocker
- Fix naming violations for SPI `Address` and `Command` enums #2906 [jessebraham]
  There are still a handful of enums which violate this rule, but they are not in drivers which are being stabilized,...
- Restore explicit stdin inherit #2927 [bugadani] skip-changelog
  Command::output opens a pipe for stdin, which macOS can't seem to handle and running examples fail.
  - JurajSadel
  - MabezDev
- GPIO: The author must to use `crate::any_peripheral` to define the "any" peripheral instance type. #2707 [bugadani] peripheral:gpio
  - bugadani: At the very least this is an implementation detail and shouldn't be a blocker if we even want to...
  - MabezDev: We should probably relax this to should, but this is again one of those situations where we're...
- Fix thread-mode executor on core1 not waking up #2924 [bugadani]
  Found while testing #2701 - apparently this is an unrelated issue :) Bug was caused by...
  - MabezDev: Makes sense, thanks!
  - Dominaezzz
- support embassy-net with simplified lifetimes/generics #2385 [jsprog] status:blocked upstream
  Motivations embassy-net simplified lifetimes/generics since be0d977 (Sep 16, 2024). Sooner or later, esp-hal need to...
  - bugadani: I think #2849 was supposed to close this.
- I2C: If your driver provides a way to listen for interrupts, the interrupts should be listed in a `derive(EnumSetType)` enum as opposed to one function per interrupt flag. #2768 [bugadani] peripheral:i2c 1.0 non-breaking
  It does not, but it should, so I'm marking this as an omission.
  - MabezDev: We're not stabilizing interrupts for 1.0 (context: #2900 (comment)), so we can add this post 1.0
- I2C: allow listening for interrupts #2600 [bugadani] peripheral:i2c 1.0-blocker
  While we can bind an interrupt handler, we don't currently provide a way to actually listen for interrupts.
  - MabezDev: I consider this a dupe of #2763
- C-QUESTION-MARK: Examples use ?, not try!, not unwrap #2811 [bugadani] peripheral:uart 1.0 non-breaking
  - playfulFence: Last night I wanted to end the day with this issue as a quick win, but something went...
  - bugadani: ? is not applicable in the context of the main function in our driver, so the doc example will...
  - playfulFence: Closing this
- Stable driver: UART #2495 [MabezDev] peripheral:uart api 1.0-blocker
  As part of #2491, which has more details on driver analysis. esp-hal API-GUIDELINE omissions #2632 #2633 #2634 ...
- GPIO documentation issue: `C-QUESTION-MARK` #2714 [bugadani] documentation peripheral:gpio 1.0-blocker
  - playfulFence: As per #2811 (comment)
- UART driver does not support autobaud functionality #2641 [jessebraham] peripheral:uart 1.0 non-breaking
  - bugadani: I've removed my assignment and I think we can remove the 1.0-blocker label as well.
- Legalize `C-QUESTION-MARK` violation #2929 [playfulFence] skip-changelog
  as per #2811 (comment)
  - bugadani: Suggested change -...
    - JurajSadel: 🤣
  - bugadani
  - jessebraham
- Mark unstable modules, make `macros` private #2900 [playfulFence] skip-changelog
  Description closes #2499 potentially closes #2921 Marked the rest of unstable modules. Makes macros module private...
  - bugadani: This macro should probably live in an internal_analog or similar module, rom seems somewhat...
    - MabezDev: This macro should probably live in an internal_analog or similar module The only issue that...
  - bugadani: This is probably something that can be fixed in instability.
  - bugadani: entry quite obviously needs to be stable - if you can't write main, how would you use the crate?
  - playfulFence: Exactly, that's what I'm talking about 😅 Which means, we need to either stabilize esp_riscv_rt...
  - playfulFence: UPD: marked entry, handler and ram as unstable only for docs since "truly" marking them as...
  - MabezDev: esp-hal-procmacros is basically tied to esp-hal, the only reason they're in separate a crate is...
  - MabezDev
    - MabezDev: I don't recall the discussion where we decided to make these unstable, could you revert this,...
    - MabezDev: Using Spi + Blocking + Interrupts should be stable from 1.0, please remove this
  - MabezDev: LGTM, thanks! Some of the smaller things can be tackled outside this PR, but let's get this...
  - JurajSadel: Thanks for working on this!
- Mark unstable APIs #2499 [MabezDev] api beta-blocker
  We need to mark APIs we're not stabilizing as such. These are all APIs except...
- Mark procmacros as unstable #2921 [MabezDev] beta-blocker
  See the discussion here #2900 (comment) The exception to this, will be the main macro, once added in #2920
- Make `set_interrupt` panic free #2760 [bjoernQ] peripheral:interrupt
  set_interrupt implementations can panic because Priority contains the None variant. IIRC we use it internally for...
  - MabezDev: As per #2900 (comment) we're not planning to stabilize interrupts, therefore I'm removing the...
- Remove the single byte read/write inherent functions #2808 [bjoernQ] peripheral:spi 1.0-blocker
  - SergioGasquez: Uart also has read_byte and write_byte
- Stable driver: SPI master #2494 [MabezDev] peripheral:spi api 1.0-blocker
  As part of #2491, which has more details on driver analysis. Note: we are not stabilizing DMA support right...
  - playfulFence: C-QUESTION-MARK violation is legal now: #2811 (comment) Deleted it from this list
- Remove the single byte read/write inherent functions #2915 [JurajSadel]
  closes #2808 cc #2882
  - SergioGasquez: Thanks for working on this, left some nitpicks, some of them can be ignored, I guess
  - SergioGasquez: We could also delete these and just replace the instances where its used with the equivalent...
    - JurajSadel: I left this so it is "consistent" with read_byte and I marked this one as private in UartRx.
  - SergioGasquez: We should also remove the read_byte method from UartRx and write_byte from UartTx
  - JurajSadel: We should also remove the read_byte method from UartRx and write_byte from UartTx I made...
  - bjoernQ: nitpick but buff is a bit uncommon - I'd prefer bufor buffer
  - bjoernQ: You could expand on this a little bit - like mentioning to use a one byte sized buffer and...
  - bugadani: Let's say they have been removed
  - bugadani: What about them?
    - JurajSadel: Forgot to remove this line, removed now.
  - bugadani: We'll have to take a bit of care here. UART's read_bytes is not blocking, SPI's read_bytes is...
  - bjoernQ: LGTM
  - SergioGasquez: LGTM!
- Expose SPI sio() setting #1826 [ElDonad] peripheral:spi 1.0 non-breaking
  Hello, I was trying to setup three wires SPI for my application using an ESP32-S3, and it appears that the esp-hal...
  - MabezDev: As per the pending PR, this can be done, and if we wanted it could even be added post 1.0.
- GPIO: If a common Instance trait is used for multiple peripherals, those traits should not have any logic implemented in them. #2713 [bugadani] peripheral:gpio 1.0-blocker
  This mostly covers the different Pin traits, I believe.
- C-VALIDATE #2787 [bugadani] peripheral:i2c 1.0-blocker
  write, read, write_read and transaction do not validate the address
  - MabezDev: Given that write, read, write_read and transaction all return errors, we can add this validation...
- I2C: Generally, follow common "good practices" and idiomatic Rust style #2770 [bugadani] peripheral:i2c 1.0 non-breaking
  We have commented-out code, at least one FIXME and TODO in the codebase.
  - MabezDev: I don't think these are user facing issues worth blocking on. It seems timeout will be resolved by #2864
- Expose all the CS signals (The SPI hardware can take multiple CS pins and turn them on/off for each transfer. Software CS shouldn't be the long term solution for shared buses) #2795 [bjoernQ] peripheral:spi 1.0 non-breaking
  - MabezDev: Given that we're marking the current with_cs hardware cs method as unstable, and we're not...
- `AtCmdConfig` should be a part of `Config` #2732 [MabezDev] peripheral:uart 1.0 non-breaking
  - MabezDev: I think we should mark the whole AT command stuff as unstable for now, I've created #2930 to track this.
- Using multiple GPIO interrupts is not supported yet (e.g. 4 on P4) #2650 [bjoernQ] peripheral:gpio
  - MabezDev: We're not stabilizing interrupts for 1.0 (context: #2900 (comment)), so we can't punt this till post 1.0
  - MabezDev: @tommasoclini please file a separate issue.
  - tommasoclini: Are there any issues with the GPIO interrupts? I'm getting a weird behavior in the attached...
  - tommasoclini: I will, should i attach the whole project with Cargo.toml and Cargo.lock, or is the code snippet fine?
- GPIO `C-HIDDEN` violations #2697 [MabezDev] peripheral:gpio 1.0-blocker
  Things to make private or doc-hidden AlternateFunction Pin trait (anything but number,mask,degrade cannot be called...
  - bjoernQ: we still need to agree if we want the mentioned traits to be hidden or not - if not #2856 should...
  - bugadani: I don't think we want the pin traits hidden - although InputPin and OutputPin are implemented...
  - MabezDev: I believe this is implemented in #2926
- Remove logic from InputPin and OutputPin #2926 [bugadani] skip-changelog
  I'd say this closes #2713 Pin's number and degrade remain public. input_signals and output_signals remain "private"....
  - MabezDev: LGTM, thanks!
    - MabezDev: Do we have an issue for this one? Sounds like a bug in waiting for a user tries to use the same...
      - bugadani: #2928
  - bjoernQ: LGTM
- C-INTERMEDIATE #2784 [bugadani] peripheral:i2c 1.0-blocker
  Should write, read, write_read return the number of transmitted/received bytes on error? Should transaction return...
  - MabezDev: Closing this in favour of the general one: #2820, it expands a bit more on the idea above.
- i2s: fix pin offset for 8bit parallel on i2s1 #2886 [liebman]
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
- Support 3-wire-SPI #2919 [bjoernQ]
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - bugadani: Should we use Unsupported instead?
  - MabezDev: I think we need some more comments in both functions to tell the user when they need MOSI or...
- De-allocate memory used by timers on removal #2936 [bjoernQ]
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - bugadani: Honestly I'm very sad reading code like this, but if it works, it works.
  - bjoernQ: Honestly I'm very sad reading code like this, but if it works, it works. That whole file makes...
  - JurajSadel: Thanks!
- Debug and re-enable I2S tests on ESP32 #2440 [bugadani] CI tests peripheral:i2s chip:esp32
  Disabled in #2439 due to noise.
  - bugadani: A (probably separate) ESP32 I2S issue can be reproduced by liebman/esp-hub75@e5f8392 Placing an...
- I2C: Prefer `cfg_if!` over multiple exclusive `#[cfg]` attributes. #2771 [bugadani] peripheral:i2c maintainability
  We are good here, although multiple versions of the same function exist which violates this rule. The solution,...
  - bugadani: This probably isn't a blocker, it was marked that way because of the review process. We've...
- Stable driver: GPIO #2492 [MabezDev] peripheral:gpio api 1.0-blocker
  As part of #2491, which has more details on driver analysis. esp-hal API-GUIDELINE omissions Revisit: Private...
  - playfulFence: C-QUESTION-MARK violation is legal now: #2811 (comment) Deleted it from this list
- Prepare 1.0 road map dev portal blog post #2502 [MabezDev] documentation beta-blocker
  This shouldn't really be tracked here under esp-hal, but for now it's the best place to ensure we don't forget about...
- Possible interrupt footgun on multicore systems #1525 [MabezDev] beta-blocker
  Now that the interrupt is handled internally by the peripheral driver, the interrupt is configured for the core the...
- Should we get rid of nb::Result for inherent functions? #2807 [bjoernQ] peripheral:spi beta-blocker
  Should be a general decision - not just for SPI. If we don't want that - what about embedded-hal-nb?
- SPI: one of the half-duplex modes is not supported #2687 [bugadani] peripheral:spi beta-blocker
  I can't actually tell whether the half-duplex mode we support is 3 or 4-wire single-bit. Our data modes are defined...
  - bjoernQ: I guess we reached consent here? (i.e. add a data mode for three-wire SPI) If yes, I can assign...
- Evaluate the `Peripheral` and `Peripheral` ref module #2661 [MabezDev] api 1.0-blocker
  For various issues, documentation and soundness issue, for example are we affected by embassy-rs/embassy#2919
- RFC: Provide consistent APIs for configuring clock sources for peripheral drivers #1668 [jessebraham] RFC 1.0-blocker investigation
  From this project's inception we've just been hard-coding the clock source for peripheral drivers (usually just...
  - bugadani: Hmm a three-way split doesn't solve the problem that we have with spooky action in the distance....
  - MabezDev: I agree with @bugadani that split probably isn't ready let's mark it (and the halves) as...
  - MabezDev: I'm still a bit concerned with clock source being runtime settable via config. Whilst we can...
  - bugadani: I don't understand why we need to special-case the clock source config.
  - Dominaezzz: Afaia, there are two things to take into account when choosing a clock source. Picking the...
- GPIO: The driver's constructor should take the config struct by value, and it should return `Result<Self, ConfigError>` #2708 [bugadani] peripheral:gpio beta-blocker
  In case the driver's configuration is infallible (all possible combinations of options are supported by the...
- Updated PACs and made the Wi-Fi peripheral non virtual on the ESP32-S2. #2942 [Frostie314159]
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - bugadani: 🫀
  - jessebraham: Thanks!
- Remove Pin trait impls from Flex #2938 [bugadani]
  The sleep APIs are unstable and these traits are also marked as "unfortunate implementation details" (by me...) so I...
  - bjoernQ: LGTM
- Make Uart::read_bytes blocking #2935 [bugadani]
  Hopefully this is right, errors and expectations around them are tricky when one doesn't get enough sleep.
  - SergioGasquez: LGTM! I like the idea of having read_bytes blocking and read_buffered_bytes
  - bjoernQ: LGTM
- Update Xtensa Rust version #2940 [SergioGasquez] skip-changelog
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - bjoernQ: LGTM
  - bugadani
- Remove internal_pull_in_sleep_mode #2937 [bugadani] skip-changelog
  These functions are only available on the interconnect types, and even there they are hidden. We'll have to come...
  - bjoernQ: LGTM
  - playfulFence
- Expose the KEEP_CS_ACTIVE option (This is important for chunked transfers in a single transaction) #2797 [bjoernQ] peripheral:spi 1.0 non-breaking
  - MabezDev: For the same reasons as #2795, this can be implemented later.
  - Dominaezzz: Unlike #2795 I don't think this can come later. This is not the sort of setting one puts in a...
  - MabezDev: If there was some kind of TransferConfig struct There will be something like this, probably...
  - Dominaezzz: Regardless, this is strictly to do with segmented transfers, right? No, this applies to CPU...
  - bugadani: We might go in the same direction as with I2C transfers, and provide a low-level transaction api...
  - Dominaezzz: We might go in the same direction as with I2C transfers That would be a little too restrictive...
  - bugadani: How do you know it would be restrictive? We haven't even started to design it. Anyhow, PRs are...
  - Dominaezzz: How do you know it would be restrictive? We haven't even started to design it. Because I've...
- Main macro #2941 [bjoernQ] skip-changelog
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - jessebraham: Probably these should just go in the __macro_implementation module instead?
    - bjoernQ: or no .... we need them to be public even without the "unstable" feature
    - MabezDev: in that case let's make __macro_implementation stable but doc(hidden), I agree with Jesse that...
  - MabezDev
    - MabezDev: Could we expand this a bit to also give a direct code snippet, something like #[esp_hal_embassy::main]
    - MabezDev: Are these used/required?
      - bjoernQ: oops - I thought I removed them before the commit 🤦‍♂️
  - MabezDev: LGTM, thanks!
  - JurajSadel: Thanks!
- macros: Add `#[main]` macro #2920 [MabezDev] beta-blocker
  Description of work required is available here: #2900 (comment)
  - playfulFence: I want to discuss it a little bit more. From my point of view and understanding of a comment...
  - MabezDev: Good question, thanks for asking! I addressed this a bit in this point: A new main macro that...
  - playfulFence: On the other hand, the only option that I see is making users export entry by themselves. Which...
  - playfulFence: Thanks for clarifying, agreed, it's probably the best way how to keep things user-friendly,...
  - bugadani: So this is the third issue we have that is related to unstable crate dependencies in some...
  - MabezDev: What counts as code change? PACs, RT crates are "singleton crates", i.e. a single version can...
- i2c_master: Add interrupt APIs #2944 [JurajSadel]
  closes #2905 Adds i2c interrupts API, mark interrupt API as unstable in drivers we are stabilizing.
  - bugadani
  - jessebraham
- Add inherent `set_interrupt_handler` method to drivers #2905 [MabezDev] api 1.0 non-breaking
  We currently only implement the trait, which isn't be stabilized. We have also discussed removing the trait as it's...
  - MabezDev: As per #2900 (comment) I'm removing the 1.0 blocker, but I'll keep it in the milestone as this...
- esp_wifi eventually uses up all available memory and stops working #2892 [Mossop] bug package:esp-wifi
  Bug description I have a project I'm playing with on an ESP32C6 board to publish sensor readings to mqtt. I have...
  - bjoernQ: Thanks for the hint regarding the reconnect.I think I found the reason for the leak and hope to...
  - Mossop: Awesome. Let me know if you would like me to test anything.
  - bjoernQ: #2892 should fix the issue
  - Mossop: #2892 should fix the issue Awesome thanks. I can confirm that it solves the problem. My device...
- ESP32-S3: Fix PSRAM start address calculation #2880 [bjoernQ] skip-changelog
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - JurajSadel
  - jessebraham
- Avoid using nb::Result as a retrurn type #2882 [SergioGasquez]
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - bugadani: If we're not removing the nb package, should we at least gate it behind unstable?
  - SergioGasquez: If we're not removing the nb package, should we at least gate it behind unstable? I just...
  - SergioGasquez: I guess it would be good to resolve #2935 before merging this PR.
  - bugadani: I guess it would be good to resolve #2935 before merging this PR. No need, I don't mind...
  - bugadani: This is simply read_bytes, isn't it? Although I guess we have that enough times in tests already :)
  - bugadani: Suggested change Uart `write_bytes`...
- Avoid public API changes due to config options. #2945 [playfulFence]
  Pull Request Details 📖 Description closes #2509 This PR converts csi_enabled config option to esp-wifi crate...
  - bjoernQ: not sure the "Avoid public API changes due to config options." part is interesting for the...
    - bugadani: The changelog shouldn't contain reasoning, it should just say what changed. The why is in the PR...
  - bjoernQ: Not sure the reasoning of the change belongs here - but we have similar phrasing in other places
    - bugadani: The guide needs to spell out WHICH configuration option needs to be enabled, otherwise it's just...
  - bjoernQ: LGTM
  - bugadani
  - bugadani: 👍🏻
  - MabezDev
- Config options should not affect the public API #2509 [MabezDev] package:esp-config beta-blocker
  Continuing the discussion from #2422 (comment) We need to answer this question and then write the appropriate...
  - MabezDev: I agree, config options shouldn't affect the public API, I think we're better off adding those...
  - bugadani: Look for any other configs that change the API Well I guess it's better if I respect this in...
  - Dominaezzz: embassy-time is an interesting case since that's almost exclusively setup by the application...
- AnyTouchPin, type erased GPIO pin that implements TouchPin #2948 [Bahex] peripheral:gpio peripheral:touch
  Motivations Statically allocating space for multiple gpio pins is easy with AnyPin, but there is currently no...
  - bugadani: Good idea, I think. If we do this, we should also add the same for the rest of the pin types...
- Investigate C-INTERMEDIATE for all stabilized drivers #2820 [bugadani] 1.0-blocker investigation:done
  cc #2784
  - MabezDev: So I believe this only applies to I2C & SPI, as they are the two drivers with the concept of a...
  - MabezDev: In our triage we decided that it's unlikely to be useful to have intermediate results. Sending...
- Consider making the MSRV of each package consistent #2949 [jessebraham] CI
  Currently each package has a unique MSRV, based purely on the requirements of the given package. This is usually...
  - bjoernQ: None of these packages are intended for use with any project outside of the esp-hal ecosystem to...
  - bugadani: I'd propose moving straight to 1.84 and enabling the new cargo resolver that came with it...
- MSRV policy going forward #2736 [MabezDev] 1.0-blocker
  With #2615 we ourselves in a situation where we have to bump the MSRV even though we're not using any new compiler...
  - MabezDev: Let's go with STABLE as our MSRV policy. Now that cargo is MSRV aware, this becomes a much more...
- Bump MSRV of all packages to 1.84, add MSRV policy to each `README.md` #2951 [jessebraham]
  Closes #2949 Closes #2736
  - MabezDev: LGTM, thanks for taking care of this!
    - MabezDev: Oooo fancy!
    - MabezDev: We should add to our release process a reminder to update this link
      - jessebraham: Done!
  - JurajSadel
- Use `timer_queue` #2952 [bjoernQ] skip-changelog
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
- Minor pre-release cleanup #2950 [bugadani] skip-changelog
  I propose enabling the stable feature by default while we're still not in beta. While it's easy to opt-in, I want to...
  - MabezDev: Makes sense, thanks!
  - jessebraham
- Explore how private dependencies with `links = ` affect esp-hal #2589 [MabezDev] RFC 1.0-blocker investigation
  I'm slightly concerned that when we release 1.0 some of our deps may in inadvertently break esp-hal builds by...
  - jessebraham: Okay, so in the interest of trying to get this resolved... I believe esp-hal should include the...
  - Dominaezzz: 5. Including multiple versions of the PACs will likely be problematic Why is this? My gut...
  - bjoernQ: Including multiple versions of the PACs will likely be problematic Why is this? My gut...
  - Dominaezzz: Ah I see, could that be moved to the hal? I can easily picture an application having multiple...
  - bjoernQ: Ah I see, could that be moved to the hal? I can easily picture an application having multiple...
  - MabezDev: Thanks for taking the time to look at this! I believe esp-hal should include the links key,...
  - bjoernQ: I suppose it does stop a user depending directly on the rt crates and esp-hal at the same...
  - MabezDev: Somehow I completely missed the #[no_mangle], thanks for pointing that out. Yeah, it seems not...
  - bugadani: There can't be two versions of esp-hal in a project because we have a no-mangle...
- Uart: mark AT related functionality as unstable #2930 [MabezDev] beta-blocker
  Due to unresolved concerns in #2732
- Unstabilize AtCmdConfig #2953 [bugadani] skip-changelog
  Closes #2930
  - bjoernQ: LGTM
  - MabezDev
- I2C: support 10-bit addressing #2507 [bugadani] peripheral:i2c api 1.0 non-breaking
  As noted by #2493 (comment) We have a few options to support 10-bit addressing in inherent methods: Create separate...
  - MabezDev: In theory after #2864 this is not strictly a blocker since we should be able to add 10-bit...
- Support switching SPI pins for difference devices with same SPI peripheral #2876 [ProfFan] status:blocked peripheral:spi
  Motivations The ESP32 series has very limited number of SPI peripherals (only SPI2/3). It is possible to use CS pins...
  - bugadani: I'll cc #2778, we'll probably want to come back to this issue when we start designing our SPI...
- I2c addr #2864 [bjoernQ]
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - MabezDev: So with this way of doing things, when we add 10bit support, won't this break code like...
    - MabezDev: Based on these ideas, what about the following? drop the trait (meaning we don't need the...
  - bugadani
    - bugadani: I don't understand the need for this. I2cAddress can impl From from the possible address types.
    - bugadani: Why is this public, and what will happen when we introduce 10-bit addresses?
      - bjoernQ: can be pub(super) but since it's in a private module doesn't make much difference 10-bit address...
  - bugadani
  - bugadani: If you convert the address first, we don't need the Copy bound.
    - bjoernQ: true
  - bugadani
  - MabezDev: Just the timeout enum rename, and this will be good to go!
  - MabezDev: Update these too please
  - MabezDev: Thanks!
- C-CUSTOM-TYPE: these may be okay but we should be mindful of future changes (device-specific timeout options, 10-bit addresses) #2786 [bugadani] peripheral:i2c beta-blocker
  timeout field in Config is an Option address parameter in write, read, write_read and transaction is a u8
- I2C: more granular timeout configuration on later chips #2602 [bugadani] peripheral:i2c 1.0 non-breaking
  cc #2493
  - MabezDev: I think the way we've structured the timeout in #2864 we can add this post 1.0
- CS timings #2796 [bjoernQ] peripheral:spi 1.0 non-breaking
  - bugadani: Mmm, since we don't stably support chip selects (or, well, not at all, really), maybe we can get...
- I2C: Drivers must have a implementation resetting the peripheral to idle state. #2774 [bugadani] peripheral:i2c 1.0-blocker
  Is it an exception? For now, I can't see any reason why not to do a Drop implementation for this. IDF also has some...
  - MabezDev: I don't think this is an exception, we should do it. We can technically do this post 1.0, but I...
  - bugadani: Franky I have no idea what was in past Daniel's head. :(
  - MabezDev: I don't think there is anything actionable here actually, reset on drop is managed by the internal guard.
- Stable driver: I2C master #2493 [MabezDev] peripheral:i2c api 1.0-blocker
  As part of #2491, which has more details on driver analysis. esp-hal API-GUIDELINE omissions #2763 #2764 #2765 ...
- Program reading PWM signals with GPIO interrupts weird behavior #2932 [tommasoclini] bug
  Bug description This is the project. The goal is to read the TON of two (possibly more than two) PWM signals coming...
  - tommasoclini: What can I do to try to see what's going on? How do I catch what apparently is unlistening the...
  - tommasoclini: If I call listen in the interrupt handler whenever the interrupt flag is not set (it shouldn't...
  - tommasoclini: I've written a new version of the program, a button press calls listen on every channel. I've...
  - tommasoclini: @MabezDev, any idea?
  - tommasoclini: I've written a similar program in c++, I'm not facing the problem in that case, the logic is...
  - MabezDev: Sorry, needed a bit of time to look at this. I think whilst this might be possible with GPIO...
  - tommasoclini: Thank you, I'll think about it. Also, what could be causing the rust program to stop working...
  - tommasoclini: I tried setting ESP_HAL_PLACE_ANON_IN_RAM to true, it didn't change anything, unfortunately.
  - tommasoclini: Also, I'd like to get minimum latency for each period, so I kind of have to be able to receive a...
  - tommasoclini: Interesting. 0 corresponds to the press of the button that enables the interrupt again. 14...
  - liebman: Another option would be to use the capture module of the MCPWM peripheral. There are two MCPWM...
  - tommasoclini: Is that supported in this hal?
  - tommasoclini: I see that my issue has probably been fixed in the main branch, should I just switch to that...
  - liebman: Depending on what features you need you may need to write the registers directly (my last use...
  - tommasoclini: I don't really have time for that, I'm a solo dev working on the firmware of a 1:10 racing car...
  - bjoernQ: I see that my issue has probably been fixed in the main branch, should I just switch to that...
  - MabezDev: @tommasoclini As stated multiple times, you will be better off using dedicated hardware for...
  - tommasoclini: Well, it's not a bug only in the main branch. Anyway, how does dedicated hardware help me in...
  - tommasoclini: @bjoernQ when is 0.23 expected to be released?
  - bjoernQ: @bjoernQ when is 0.23 expected to be released? It's planned for end of this week (if nothing...
- Reconnecting an output signal to a different pin does not clear previous connections #2928 [bugadani] bug peripheral:gpio 1.0-blocker
  An example where this matters is SPI hardware chip select. Due to how the IO_MUX works, connecting a new output to...
  - bugadani: We don't do this, because we'd have to loop through all GPIOs to find which ones use the signal...
  - Dominaezzz: The GPIO signal semantics haven't been well defined and should probably be sorted out before...
  - MabezDev: We can logically OR all the pin masks that a driver uses and track the pins that way, but that...
  - bugadani: We can logically OR all the pin masks that a driver uses and track the pins that way, but that...
  - bugadani: Wait nevermind we still have to know which pin is which signal, we don't want to accidentally...
  - Dominaezzz: Wait nevermind we still have to know which pin is which signal, we don't want to accidentally...
- Update our time driver for upcoming embassy changes #2701 [bugadani] skip-changelog
  Update esp-hal-embassy for the new embassy-time-driver version. We now manage our own timer queues, which means...
  - bugadani: Well, thanks, but to add to my pain, single timer queues are broken on multicore because I...
  - MabezDev: Overall this is working well for me, I'd like to test some projects with it but I'll do that...
    - MabezDev: I think we can fix this now, our MSRV is 1.84?
    - MabezDev: Are we sure this shouldn't be a feature? Or because only one can be selected this is a use case...
      - bugadani: I thought we have a config system to use it, unless we can't for some reason. We allow...
      - MabezDev: I was making the comment to ensure we're not just emulating features in configs. Configs are...
  - bjoernQ: This is really a lot of stuff (even besides all the mechanical changes) Running tests didn't...
- C-GENERIC: `write`, `read`, `write_read` should accept `impl AsRef<[u8]>` and `AsMut` #2785 [bugadani] peripheral:i2c 1.0-blocker
  - MabezDev: IIRC, this is bad for code size. If you have a driver function that you could pass a Box<[u8]>...
  - bugadani: Code bloat could I believe largely be mitigated with the following pattern: fn outer(&mut self,...
  - MabezDev: Ah I see. I think that would work quite well with the Driver structure we have now, where 90% of...
  - bugadani: (I think technically a &T -> AsRef change would count as non-breaking?)
  - Dominaezzz: (I think technically a &T -> AsRef change would count as non-breaking?) Does breaking inference...
- ADC: Add async support for oneshot reads for esp32c3 and esp32c6 #2925 [davoclavo]
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
- Ensure the PAC crates and other private crates are never exposed publicly #2525 [MabezDev] api 1.0-blocker
  The PACs will probably never be 1.0, therefore we need to keep it out of the public API in esp-hal. This is...
  - bjoernQ: The issue is that just changing the HAL might break things. I agree with Jesse - as long as the...
  - bugadani: If they add a dependency on the PAC they add a dependency on something unstable and have to deal...
  - bjoernQ: If they add a dependency on the PAC they add a dependency on something unstable and have to deal...
  - playfulFence: I'll just leave some notes here: fugit - still a big problem here. Should we contact its'...
  - Frostie314159: I would suggest, making the types in esp_hal::peripherals not Deref to the PAC types, but...
  - bugadani: I was considering adding a register_block(private::Internal) to the singletons, but decided...
  - Frostie314159: I'm totally fine with that being unstable. The only API I currently use, that's unstable is the...
  - bugadani: I'm totally fine with that being unstable. Actually, I'd still advise against doing that :D I...
  - Frostie314159: I mean, if it would be possible, I'd definitely use stable esp-hal, but without a stable ram or...
- esp-wifi: Examples broken #2883 [bjoernQ] package:esp-wifi
  On current main wifi_embassy_access_point: DHCP server is not working anymore Enterprise wifi connect seems to be...
  - tommasoclini: Is this something that has to do with my example code?
  - bjoernQ: Is this something that has to do with my example code? I don't think so. Needs some more investigation
  - bjoernQ: Enterprise Wifi is fixed
  - jamessizeland: link to matrix thread related:...
  - bjoernQ: Thanks. Just tried on latest commit (5717608) and wifi_embassy_ble example is working fine for...
  - jamessizeland: Ok espflash erase-flash has revived the chips, so I'll try to reproduce the fault again.
  - eloycoto: Thanks. Just tried on latest commit (5717608) and wifi_embassy_ble example is working fine for...
  - jamessizeland: Thanks. Just tried on latest commit (5717608) and wifi_embassy_ble example is working fine for...
  - bjoernQ: Aha ...... it always works fine for me when flashing/running via UART-bridge, but I see the same...
  - bjoernQ: But e.g. wifi_ble example should show the same behavior, then. (and does for me - but wifi...
- `interconnect` is (probably) unsound and unclear #2954 [bugadani] bug peripheral:gpio status:needs-attention
  Because InputConnection is Clone, Send and Sync, (and to a lesser extent, OutputConnection is a superset of...
- Full-duplex mode of I2S is not working/implemented yet. #2939 [foldingbeauty] peripheral:i2s
  Bug description I'm writing a driver for the SGTL5000 audio codec chip and during testing I found out I can't read...
  - bjoernQ: Thanks! We currently use full-duplex for loopback testing in our HIL tests - maybe that helps: ...
  - foldingbeauty: @bjoernQ thanks for the quick reply. Will take a look soon. I got all the information I need.
- Remove Deref from peripheral singletons #2956 [bugadani] skip-changelog
  This PR removes the Deref implementation from peripheral singletons. Instead, a register_block(&self) and a regs()...
- Create newtypes for all PAC peripherals, mark unstable peripheral singletons #2957 [bugadani] skip-changelog
  Trying to break up #2956 into more manageable pieces :) This change wraps all PAC types we use as peripherals in a...
- Define a stable set of SPI tests #2934 [bugadani] skip-changelog
  - JurajSadel: LGTM
  - playfulFence
- Rmt: Improve codegen for enable_listen_interrupt #2960 [wisp3rwind] skip-changelog
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - bugadani: Oh hmm that's unexpectedly significant, thanks!
- Peripherals that can be split, should have their config split accordingly #2931 [MabezDev] peripheral:uart beta-blocker
  See #1668 (comment) for context. I think this only affects Uart, from the stabilized driver list. With this setup,...
  - bugadani: The control struct from split takes the full Config This part is dangerous. We shouldn't allow...
  - playfulFence: Maybe we should have only runtime-modifiable things in that Control struct?
  - bugadani: Maybe we should have only runtime-modifiable things in that Control struct? You might want to...
  - playfulFence: Does it make sense to runtime-modify StopBits, Parity or DataBits? Maybe it does though, not...
  - bugadani: Would you say it safe to modify the clock source, or the baud rate, when the peripheral is...
  - MabezDev: Would you say it safe to modify the clock source, or the baud rate, when the peripheral is...
  - bugadani: As you mentioned, UART is always listening, so this is always something the user will have to...
  - MabezDev: Let me phrase this in another way: a shared configuration object, without locking in the driver,...
- New package releases #2959 [jessebraham] skip-changelog
  - jessebraham: skip-changelog added because of the changes in esp-lp-hal
  - bugadani: We'll have to update the migration guides as well to not say 1.0, want me to send a PR to your PR? :)
  - jessebraham: Oh oops forgot about that. I can update it, thanks anyway though!
  - SergioGasquez: 💯 Looks really good!
  - bjoernQ: LGTM - testing locally didn't reveal any problems
  - JurajSadel: LGTM, thanks!
  - MabezDev: LGTM! The README is looking very slick, nice! Thanks!
- docs: RMT_CHANNEL_RAM_SIZE counts pulse codes, not bytes #2955 [wisp3rwind] skip-changelog
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
- Remove extraneous keyword from `esp-alloc` Cargo manifest #2962 [jessebraham] skip-changelog
  Can't publish this package otherwise.
  - MabezDev: Thanks!
  - bjoernQ
- GPIO filter is not supported yet #2647 [bjoernQ] peripheral:gpio 1.0-blocker investigation
  - bjoernQ: I guess for the simple filter it's just a matter of allowing to set IO_MUX_GPIOn_FILTER_EN...
- Glitch filter is not supported yet #2648 [bjoernQ] peripheral:gpio 1.0-blocker investigation
  - bjoernQ
- Data registers should not be represented with `usize` #2963 [ROMemories] bug status:needs-attention
  Bug description It seems that usize is currently used to represent registers (e.g., in TrapFrame) on some MCUs...
  - bugadani: This is one of those "technically, you are right, but practically it doesn't matter" issues. We...
  - bjoernQ: For RISC-V the pointer width is the same as the register width which makes usize a convenient...
- Expose Double Transfer Rate where supported #2803 [bjoernQ] peripheral:spi 1.0-blocker investigation
  - bjoernQ: where is this term even mentioned in any of the TRMs?
  - bugadani: Oops I may be leaking P4 details
  - bjoernQ: 🤣 ok - we could probably support that by adding variants to spi::DataMode then in a non-breaking way
- Add linker scripts (and any additional required code) to support `mcuboot` #2479 [jessebraham] linker scripts 1.0-blocker
  Build environment for the bootloader can be found here: https://github.com/jessebraham/espressif-mcuboot-docker
- Add separate config for `Rx` and `Tx` (UART) #2965 [playfulFence]
  Description related to #2931 DRAFT: The work is not done here, I'll need to address #2931 (comment) but posting that...
  - bugadani: We won't be ableto implement embassy_embedded_hal::SetConfig for this :(
- Fix priority locks on RISC-V #2964 [bugadani]
  Because we need to increment the level by one that we write into cpu_int_thresh, the value for Priority::max()...
  - bjoernQ: Thanks for adding a test for this
  - MabezDev: Thanks!
- Do not rerun HIL tests when a PR is marked ready #2958 [bugadani] skip-changelog
  Currently, when a draft PR is updated, we run CI. Then, if that PR is marked ready for review, we run HIL tests...
  - SergioGasquez: LGTM! Alternatively, we can skip HIL tests while a PR is draft. I see some value on running...
  - bjoernQ: I see some value on running hil tests for draft PRs too. I agree on that. Maybee could not run...
  - playfulFence: LGTM, thanks! I also see the point in @bjoernQ's suggestion, but I like the current solution as it is too
- Self-host documentation for all packages #2967 [jessebraham] documentation 1.0 non-breaking
- Enable self-hosting of multiple versions of documentation for any given package #2968 [jessebraham] documentation 1.0 non-breaking
- SPI: Expose timing delays #2801 [bjoernQ] peripheral:spi 1.0-blocker investigation
  MISO dummy delay dummy delay These are derived from a number of input params, including the expected bus speed etc...
  - bjoernQ: I'm not sure what this issue is asking for? SPI_DINx_MODE, SPI_DINx_NUM and SPI_DOUTx_MODE?
  - Dominaezzz: That's what it sounds like to me.
- Fix warnings & clean up #2961 [bugadani] skip-changelog
  Nightly CI has been yelling at us for some time now about these...
  - JurajSadel: There is this warning warning: unresolved link to `4:0` --> src/i2c/master/mod.rs:730:5 ...
  - bjoernQ: There is this warning warning: unresolved link to `4:0` --> src/i2c/master/mod.rs:730:5 ...
  - bugadani: t.b.h. that whole comment is questionable at best Regardless, let me try to teach CI to fail on these.
  - MabezDev: LGTM, thanks!
  - bjoernQ: LGTM
- Allow splitting the SPI FiFo into two halves (All chips support doing this, and it allows for double buffering without DMA) #2798 [bjoernQ] peripheral:spi 1.0-blocker investigation
  - bjoernQ: This seems to be related #1579
- Prepare for esp-hal@0.23.1 #2966 [MabezDev] skip-changelog
  Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...
  - bjoernQ: Thanks
  - jessebraham
  - JurajSadel
- Re-evaluate our current approach to CI #2969 [jessebraham] CI
  There are presently a number of issues with our current CI pipeline(s), many of which resulted naturally as a result...
- Confusion about usage of I2S as DAC DMA unit #1356 [Slamy] peripheral:dma peripheral:dac peripheral:i2s
  Howdy! I would like to use the DAC of the ESP32 in DMA mode. The dac.rs itself only supports direct writing to it...
  - robbie01: I'd like to note that this issue is of interest to users of the "Cheap Yellow Display" (CYD, see...
- Need a mechanism to test different esp-config configurations #2971 [bugadani] CI status:needs-attention
- esp-hal-embassy low_power_wait cannot be disabled #2970 [relufi] bug status:needs-attention
  Bug description Failed to compile after low power wait = false To...
  - relufi: esp-hal/esp-hal-embassy/src/executor/thread.rs Lines 9 to 20 in ...
  - bugadani: Thanks! For now you can spawn a task that just yields in a loop, as a workaround. Fixing this...
- (Somewhat) clean up wifi timer queue #2943 [bugadani] skip-changelog
  A bit heavy-handed maybe, but malloc tends to screw up alignment by the 4-byte offsetting it does, so I needed a...
  - bugadani: Do we know how these are used, specifically period and expire? It would be nice if we could...
    - bjoernQ: We can do whatever we want with ets_timer - it's transparent to the driver AFAIK
  - bjoernQ: I have set ESPFLASH_BAUD to 2000000 in my environment and would like to get that used (I think...
  - bjoernQ: Thanks - I hopefully can replace most of this in a future PR
- implement EspWifiRngSource for mut refs #2972 [flippette]
  EspWifiRngSource is essentially RngCore, and all RngCore methods only take a mutable reference, and there's already...