Activity since 2026-01-21

• esp-rs/esp-hal repo issues and pull requests

  • Dedicated GPIO bundle initial implementation #4819 [ttzytt]

    This PR builds on the dedicated GPIO foundation introduced in #4699 to implement dedicated GPIO bundles, which allow...

    • bugadani: This part is a bit confusing to me. all_levels is a method that can access pins outside the...

      • ttzytt: Makes sense, just made a commit for this. I think we can use the public *_ll functions if bit...

    • bugadani: # {before_snippet} is replaced by the #[doc_replace] attribute, which needs to be placed on...

      • ttzytt: Got it. I just saw that the documentation you wrote includes # {before_snippet} and #...

    • bugadani: I don't think you need to call out the specific behaviour of a different function 🤔

      • ttzytt: updated

    • bugadani: I believe we should have short code examples instead of textual description. Yes it's a lot more...

      • ttzytt: You mean for this specific function or the general style of the documentation in dedicated.rs? I...

    • bugadani: I wonder how best to show this, because this is one of the more important aspects of the design,...

      • ttzytt: Do you mean examples of multiple bundles driving the same driver? I can add a module-level example soon.

    • bugadani: I don't think this needs to be written out, the compiler guarantees this for us.

      • ttzytt: updated.

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 2 out of 3 changed files in this pull request and...

      • copilot-pull-request-reviewer: This inline comment should be removed. It presents an alternative implementation without clear...

      • copilot-pull-request-reviewer: This inline comment should be removed. It presents an alternative implementation without clear...

      • copilot-pull-request-reviewer: Trailing whitespace on this line. Remove the trailing spaces to follow coding standards. ...

      • copilot-pull-request-reviewer: The example code calls bundle.masked_levels() but the actual method is named levels(). Update...

      • copilot-pull-request-reviewer: The example code calls bundle.masked_levels() but the actual method is named levels(). Update...

      • copilot-pull-request-reviewer: These inline comments should be removed. They present alternative implementations without clear...

      • copilot-pull-request-reviewer: The documentation references non-existent methods all_levels and masked_levels. The actual...

      • copilot-pull-request-reviewer: Extra blank line. Remove this blank line to maintain consistent spacing in the codebase. ...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 2 out of 3 changed files in this pull request and...

      • copilot-pull-request-reviewer: There is trailing whitespace at the end of this line that should be removed. ...

      • copilot-pull-request-reviewer: This inline comment should be removed before merging. It appears to be implementation notes that...

      • copilot-pull-request-reviewer: These inline comments should be removed before merging. They appear to be implementation notes...

      • copilot-pull-request-reviewer: This inline comment should be removed before merging. It appears to be implementation notes that...

      • copilot-pull-request-reviewer: This inline comment should be removed before merging. It appears to be implementation notes that...

      • copilot-pull-request-reviewer: There is an extra blank line here that should be removed for consistency with the rest of the...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 2 out of 3 changed files in this pull request and...

      • copilot-pull-request-reviewer: The documentation comment has trailing whitespace after the triple slash. This is inconsistent...

      • copilot-pull-request-reviewer: There is an inline comment discussing an alternative implementation. This should either be...

      • copilot-pull-request-reviewer: There is an inline comment discussing an alternative implementation. This should either be...

      • copilot-pull-request-reviewer: The documentation comment has trailing whitespace after the triple slash. This is inconsistent...

      • copilot-pull-request-reviewer: The documentation comment has trailing whitespace after the triple slash. This is inconsistent...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 2 out of 3 changed files in this pull request and...

      • copilot-pull-request-reviewer: There is trailing whitespace at the end of this line (after the inline comment). Consider...

      • copilot-pull-request-reviewer: There is trailing whitespace at the end of this line (after the inline comment). Consider...

      • copilot-pull-request-reviewer: Missing blank line between method declarations. There should be a blank line before the...

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 2 out of 3 changed files in this pull request and...

      • copilot-pull-request-reviewer: Trailing whitespace should be removed from this comment line.

      • copilot-pull-request-reviewer: Trailing whitespace should be removed from this blank line. Suggested change

      • copilot-pull-request-reviewer: Inconsistency in documentation: this should use self.mask() (with parentheses) to match the...

      • copilot-pull-request-reviewer: Inconsistency in documentation: this should use self.mask() (with parentheses) to match the...

    • ttzytt: @bugadani Really nice work, thank you for it! I left a few comments, I hope you don't mind, but...

  • Mark more things unstable #4811 [JurajSadel]

    This PR marks RxControlInfo unstable, RxControlInfo::from_raw is no longer public, marks csi, event and sniffer...

    • bjoernQ

  • Fix nightly CI #4829 [JurajSadel] skip-changelog

    closes #4828

    • MabezDev: Thanks!

  • esp-backtrace: Option to reset instead of halting #1586 [bugadani] package:esp-backtrace

    Halting is fine for development, but I can't really expect end-users to grab a pair of tweezers and short a pair of...

    • bjoernQ: Maybe something to add as a "bonus chapter" for esp-rs/no_std-training#80

  • Bikeshed `ModeConfig` to something more appropriate #4776 [MabezDev] RFC

    See the discussion on this here: #3958 (comment)

    • MabezDev: My suggestion: Change Config into ControllerConfig and ModeConfig into Config (then...

  • `AccessPointConfig` and `csi` return/take u8 instead of `SecondaryChannel` #4795 [MabezDev]

    This is exposing blob impl details.

  • esp-radio: `RxControlInfo`, `AccessPointConfig`, and `WifiCsiInfo::secondary_channel()` now uses `wifi::SecondaryChannel` instead of `u8` #4818 [JurajSadel] skip-changelog

    I don't think this is worth of a changelog entry? closes #4795

    • bjoernQ: this is seconds - not the secondary channel

      • JurajSadel: Regarding the times, I opened #4832 for checking the rest of the codebase.

      • bjoernQ: that new issue could use some details - no need to analyze everything now, but if you already...

    • MabezDev: LGTM, thanks!

  • Top level example #4791 [MabezDev]

    In esp-hal, we have some top level code example showing a min use case of the hal:...

    • bjoernQ: I agree showing that would be very helpful! At least we hint the user if they don't init...

  • Reconsider the WiFi event API #4744 [bjoernQ] RFC

    Problem Statement We expose users to the events emitted by the WiFi drivers via the wait_for_event family of...

    • bjoernQ: ... it doesn't prevent us from exposing the lower level events later, either ... Thanks for...

  • Wifi Controller config (`Config`) refactor #4806 [MabezDev]

    It seems to me this Config is trying to be many things at once, it has a mix of one time configuration (passed to...

  • Change `Config` into `ControllerConfig` and `ModeConfig` into `Config` #4833 [MabezDev]

    As per the outcome of #4776. I suggest the assignee of this issue also assigns themselves #4806 as there will be a...

  • Use types from `esp_hal::time` where appropriate #4832 [JurajSadel] package:esp-radio

    cc #4818 (comment) I guess this doesn't make sense to change as it already has requirements which have to be...

  • Migrate to bt-hci 0.7 (and optionally still support 0.6) #4827 [ivmarkov] feature request

    Motivations trouble main already did it.

  • i2c master document use of internal pull-ups and add an option to disable them #4830 [ChocolateLoverRaj] investigation feature request

    Motivations I was having issues using i2c between a esp32c3 and stm32. I am now pretty sure the issue is fixed by...

  • Improve hil docs #4825 [SergioGasquez] skip-ci-non-code-change

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

  • Remove `ModeConfig::None` variant #4805 [MabezDev]

    • bjoernQ: It made sense before when someone created an AP for configuration and then wants to shut it down...

  • esp-radio: Remove `wifi::ModeConfig::None` #4834 [JurajSadel]

    closes #4805

    • JurajSadel: Do we want to keep Default here?

      • AnthonyGrondin: I don't think it makes sense to keep it, especially with None being removed. The intent of using...

    • MabezDev: LGTM, thanks!

  • ESP32-C5 - Support in esp-println #4737 [MabezDev] chip:esp32c5

    Yes, we may remove this, but esp-println will be here for at least a couple of months and its easy to add support...

    • bjoernQ: See playfulFence#27

  • `ScanMethod` appears unused and unstable #4802 [MabezDev]

    We should probably use it in the scan config? Regarding its stability, I'm not sure, I suppose it can stay unstable for now.

    • bjoernQ: From a quick look it's used in StationConfigand it's used in apply_sta_config (to populate...

  • `xtask` command to use a local registry #4655 [bjoernQ] skip-changelog

    This explores the idea of #4532 It's using a local registry (in the file system) instead of using a full-fledged...

    • MabezDev: I ran into an issue when following the steps above: error: failed to sync Caused by: failed...

    • bjoernQ: I added a workflow but I refrained from refactoring the workflows for now - turned out the...

    • MabezDev: Overall this looks good to me! I would still like to eventually turn the CI workflow into a...

      • MabezDev: Suggested change ScrapPathDeps, ...

  • WifiDevice docs should be use `Wi-Fi` terminology to be consistent #4800 [MabezDev]

  • esp-radio: Use types from `esp_hal::time` where appropriate #4835 [JurajSadel] skip-changelog

    This PR doesn't address points 1, 4, and 5 from the issue as I don't think it's a correct thing to do. closes #4832

    • MabezDev: Isn't this already a timestamp, why are we now adding EPOCH to it?

      • JurajSadel: I think we want to have an Instant instead of Duration for the timestamp fields - and with this...

      • bjoernQ: Seems it's just because there is no way to "just create" an Instant?

  • xtask: Explore if we can make `run elf` also run specific tests (e.g. `esp_radio::wifi_controller::tests::test_scan_doesnt_leak`) #4836 [playfulFence] CI automation

    #4831 (comment)

  • ESP32-C5 - Support in esp-backtrace #4736 [MabezDev] chip:esp32c5

    • bjoernQ: With the changes already made it "just works" - see https://github.com/bjoernQ/hello-c5/tree/println

  • CI: Explore the possibility of using `required` to reduce duplication (not only?) in `dispatch` #4840 [playfulFence] CI

    See #4831 (comment)

  • Allow running selected HIL tests with `--test`, document this command #4831 [playfulFence] skip-changelog

    • JurajSadel: Suggested change

    • JurajSadel: /hil esp32c2 --test misc_non_drivers

    • JurajSadel: /hil esp32c3 --tests misc_non_drivers

    • JurajSadel: /hil esp32c2 --test misc_non_drivers This seems to NOT run tests from misc_non_drivers based on...

    • github-actions: Triggered HIL run for #4831 (chips: esp32c2). Run:...

    • github-actions: Triggered HIL run for #4831 (chips: esp32c3). Run:...

    • playfulFence: I bet it will work after this PR lands 😅 Now it's using current GH code in main, if I'm not mistaken

    • bjoernQ: /hil esp32c2 --test misc_non_drivers This seems to NOT run tests from misc_non_drivers based on...

    • bjoernQ: I guess we could make this work as expected by changing the xtask's "run elf"...

      • playfulFence: I think it's doable, let's explore it in #4836

    • bjoernQ: random thought but could we use require to include the common (currently duplicated) code?

      • MabezDev: Now that would be great, can we try and explore this in another issue?

      • playfulFence: Now that would be great, can we try and explore this in another issue? #4840

    • bjoernQ: I think this does what the title is promising - I had some "random" notes which we might or...

    • SergioGasquez: LGTM! Thanks

  • [esp-bootloader-esp-idf] Get rid of references in FlashRegion #4687 [furrycoding] package:esp-bootloader-esp-idf feature request

    Motivations In most applications non-volatile storage needs to be used in at least 2 places: reading and writing....

    • B83C: Ran into issues with multiple mutable references to flash due to ota holding it during its...

    • tshakah: What if you had an OTA module and an NVS module that wrote config? You'd still need some way for...

  • [esp-bootloader-esp-idf] Use zerocopy for PartitionEntry instead of storing references to partition table. #4838 [B83C] package:esp-bootloader-esp-idf feature request

    Motivations So, initially PartitionEntry was defined as follows: /// Represents a single partition...

    • B83C: I have added the PR here: #4839

    • bjoernQ: Related: #4687

  • Remove redundant RTC clock initialization #4843 [bugadani] skip-changelog

    This PR removes a bit of legacy code for #4502.

    • bugadani: /hil full I may be deleting something silently important

    • github-actions: Triggered full HIL run for #4843. Run:...

    • copilot-pull-request-reviewer: Pull request overview This PR removes legacy RTC clock initialization code that manually set RTC...

    • MabezDev: LGTM, thanks!

  • Potential unsoundness in the old SHA driver #4708 [ivmarkov] bug peripheral:sha

    Bug description It seems to me that the Borrow here is unsound, in that multiple ShaDigest instances can hold on to...

  • WiFi still works now after light-sleep (w/o powering down modem) #4826 [bjoernQ]

    This at least partially addresses #3751 (not sure if we should close that and open new issues instead) - might also...

    • bjoernQ: Looking at all the other chips this is a better default

      • bjoernQ: I'd like to measure the change in power consumption after this Sure - that's very welcome -...

    • bugadani: Can we have a QA test for this? I don't agree with these changes but if they work, we need a way...

  • Remove disscusion link #4846 [SergioGasquez] skip-changelog skip-ci-non-code-change

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani

  • WiFi intialization fails with invalid argument error when secure boot v2 is enabled #4770 [renkenono] bug investigation

    Bug description In attempt to enable secure boot V2 for our ESP32C6-based devices, I encountered a crash when...

    • bjoernQ: I am curious to know how you find the issue and understand it better :) I would love to tell...

  • Avoid additional load seg inserted by espflash #4847 [bjoernQ] skip-changelog

    Currently on C6/H2 we see a "random" load segment when booting I (76) esp_image: segment 0: paddr=00010020...

    • bugadani: What does this PR do in detail? Looks to me like we're abusing something in espflash that throws...

    • bjoernQ: What does this PR do in detail? Looks to me like we're abusing something in espflash that throws...

    • MabezDev: A good test for whether this code change is valid or not, might be to also test with esptool. It...

    • MabezDev: Maybe this should be + ALIGN(.text)?

      • bjoernQ: we need a gap >4 bytes to not let the tooling merge the segments - and (almost always)...

    • bjoernQ: A good test for whether this code change is valid or not, might be to also test with esptool. It...

    • bjoernQ: /hil full

    • github-actions: Triggered full HIL run for #4847. Run:...

  • CI: Skip CI with `skip-ci-non-code-change` label #4773 [JurajSadel] skip-changelog skip-ci-non-code-change

    With this PR, CI (triggered by pull_request) should not run when skip-ci-non-code-change is present. When the label...

    • MabezDev: I think we can make this work by: Setting an env variable on the skip status: SKIP_CI: ${{...

    • JurajSadel: I think we can make this work by: Setting an env variable on the skip status: SKIP_CI: ${{...

    • JurajSadel: With current ugly "solution" it does what we want it to do - I don't think we can make it any...

    • MabezDev: Hmm, I suppose its not too bad. I agree with you, that I'm not sure we can get much better than this.

  • Add `skip-ci-non-code-change` label to skip full CI #4759 [MabezDev] CI

  • Review `WifiError`'s variants #4796 [MabezDev]

    We should ensure we're not listing something we currently don't emit. We must also gate various variants behind...

    • bjoernQ: Maybe we also have some variants which should not happen if our code is correct (the list might...

  • Use zerocopy in place of references for the definition of PartitionEntry #4839 [B83C]

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • bugadani: Can we use the PACs here?

      • bjoernQ: I think with the exception of H2/C6 we don't have the necessary registers in the SVDs, yet. (Ofc...

  • `embassy_coex` example's BT advertisements not visible to a Windows machine #4772 [bjoernQ] package:esp-radio

    embassy_coex example's BT advertisements is not visible to a Windows machine - but it shows up in nrfConnect on...

  • Remove `WifiMode` #4798 [MabezDev]

    I don't see the point of this struct, shouldn't we be using ModeConfig instead to device the mode?

    • bjoernQ: Looked into it a bit more and we use it in quite a few places internally - inlining that code...

  • Rework / deduplicate clock calibration #4848 [bugadani] skip-changelog

    This PR removes old clock calibration code and replaces it by the same underlying implementation used by 32/C2 clock...

    • github-actions: Triggered full HIL run for #4848. Run:...

    • bugadani: /hil full

    • github-actions: Triggered full HIL run for #4848. Run:...

    • github-actions: Triggered full HIL run for #4848. Run:...

    • copilot-pull-request-reviewer: Pull request overview This pull request reworks and deduplicates clock calibration code across...

      • copilot-pull-request-reviewer: The call to clocks::timg0_function_clock_frequency(clocks) is inside a #[cfg(not(esp32))] block...

        • bugadani: Technically true, and we should solve this by adding a feature flag to metadata, but also...

    • bjoernQ: should we have a "timeout" here in case RtcClock::calibrate never succeeds?

      • bugadani: probably, but I don't think we had one before

      • bugadani: I've dropped the loop completely, it's pointless. esp-idf loops because it can automatically...

    • MabezDev: LGTM, thanks!

  • Make sure .flash_desc and .rodata are merged by the tooling #4844 [bjoernQ]

    Fixes #4842 If some input section with an alignment >4 is going into .ro_data we might produce a gap between...

    • bugadani: I would like to see a HIL test for this

    • bjoernQ: /hil full

    • github-actions: Triggered full HIL run for #4844. Run:...

    • MabezDev: This being static probably puts it in .rwdata or more likely bss, we should const this and/or...

      • bjoernQ: it goes into .rodata misc_non_drivers[ab9478271f7a08ef]::simple::tests::can_boot::ALIGNED ...

    • MabezDev

    • bugadani: This is used, right, so this attribute is not necessary?

      • bjoernQ: well I would agree but the compiler didn't 🤷‍♂️ I can double check however

      • bjoernQ: ah 🤦‍♂️

  • ESP32-C6 asserts on boot when using serde_json #4842 [AlyoshaVasilieva] bug

    Bug description While beginning work on a weather project (grabbing forecast from an API, displaying it) my ESP32-C6...

  • Quick HIL run progress report seems wrong #4850 [bugadani] bug CI

    https://github.com/esp-rs/esp-hal/actions/runs/21401337449 finished succesfully, but because this was a quick run,...

  • Tweak cfg gates #4849 [bugadani] skip-changelog

    Changes extracted from playfulFence#28

    • bugadani: /hil quick

    • MabezDev

    • bjoernQ: @bugadani Maybe I missed something but what's the deal about soc_has_etm vs etm? (i.e. is it...

    • copilot-pull-request-reviewer: Pull request overview This PR aligns various cfg gates with the newer SoC-level capability flags...

    • bugadani: soc_has_x is "hardware exists", x is "driver is enabled".

    • bjoernQ: soc_has_x is "hardware exists", x is "driver is enabled". Oki - makes sense - maybe something...

    • bugadani: I think we can rename the cfgs to be more obvious, and then the C5 bringup shows that there is...

    • github-actions: Triggered quick HIL run for #4849. Run:...

  • Remove more legacy clock code #4851 [bugadani]

    cc #4502

    • bugadani: Not yet removing RtcClock because there is no public alternative

    • copilot-pull-request-reviewer: Pull request overview This PR continues the clock tree rework by removing legacy RTC clock...

  • Fix some UART-related issues (#4586) #4852 [MabezDev]

    Backport of #4586

    • bugadani

  • Correct S2 dbias values #4824 [bugadani] skip-changelog

    • copilot-pull-request-reviewer: Pull request overview This PR corrects the voltage (dbias) control logic for the ESP32-S2 chip...

      • copilot-pull-request-reviewer: The identifier esp32s2 is not in scope in this module. The esp32s2 PAC crate is re-exported as...

    • bjoernQ

  • If a cherrypick fails, PR with the conflicts for manual intervention #4853 [MabezDev] skip-changelog skip-ci-non-code-change

    I missed #4586 (comment) but luckily @bugadani caught it. This PR changes the backlog action to create the PR...

    • copilot-pull-request-reviewer: Pull request overview Updates the backport workflow so that a backport PR is still created even...

      • copilot-pull-request-reviewer: The experimental input is currently a JSON string embedded in YAML double-quotes with escaped...

    • bugadani

    • copilot-pull-request-reviewer: Pull request overview Copilot reviewed 1 out of 1 changed files in this pull request and...

    • MabezDev: Skip doesn't seem to work in the merge queue, cc @JurajSadel any ideas?

  • use 1.93 in CI #4845 [MabezDev] breaking-change-esp-hal

    Thank you for your contribution! We appreciate the time and effort you've put into this pull request. To help us...

    • MabezDev: /hil full

    • copilot-pull-request-reviewer: Pull request overview This PR updates the Rust xtensa-toolchain version from 1.92.0.0 to...

      • copilot-pull-request-reviewer: The xtensa-toolchain version was updated to 1.93.0.0 in this job, but there's another use of...

    • github-actions: Triggered full HIL run for #4845. Run:...

    • MabezDev: /hil full

    • github-actions: Triggered full HIL run for #4845. Run:...

  • Initial P4 support tracking issue #2285 [MabezDev] status:blocked chip:esp32p4

    Whilst we don't intend to do a full chip bring-up until the mass production version is released, we would like to...

    • florianL21: Looking at #3857 this seems to be unblocked right? I have a P4 dev board in my hands right now...

    • rdelfin: @florianL21 have you identified what work is missing? I'd also like to help too to try it out!

    • florianL21: @rdelfin I already did a bunch of work but it's not yet compiling. I am actively working on it...

    • bugadani: It's possible that I am doing some things incorrectly but I have to reverse enginner stuff based...

    • florianL21: Yes I noticed that sometimes the concepts you have so far do not really fit all that well to...

created at 2026-01-28 02:20 by dinghy 0.13.1.